Fix for name mismatched cmake warning.#3
Open
sleepyspider1 wants to merge 1 commit into
Open
Conversation
|
Would be nice if this could be merged! |
|
Thank you |
glebm
added a commit
to glebm/devilutionX
that referenced
this pull request
Apr 11, 2021
|
For compatibility with older versions, it'd be better to do something like this instead: if(SDL2MAIN_LIBRARY)
if(${CMAKE_VERSION} VERSION_GREATER_EQUAL "3.17.0")
FIND_PACKAGE_HANDLE_STANDARD_ARGS(SDL2main
REQUIRED_VARS SDL2MAIN_LIBRARY SDL2_INCLUDE_DIR
VERSION_VAR SDL2_VERSION_STRING
NAME_MISMATCHED)
else()
FIND_PACKAGE_HANDLE_STANDARD_ARGS(SDL2main
REQUIRED_VARS SDL2MAIN_LIBRARY SDL2_INCLUDE_DIR
VERSION_VAR SDL2_VERSION_STRING)
endif()
endif() |
glebm
added a commit
to glebm/devilutionX
that referenced
this pull request
Apr 11, 2021
AtkinsSJ
added a commit
to AtkinsSJ/yak-2
that referenced
this pull request
Feb 14, 2022
I went on a wild goose chase trying to get cmake to properly link with SDL_ttf, and in the end, deleting the build directory fixed it. But, these cmake files seem good so I'll keep them. They came from [here] (https://github.com/aminosbh/sdl2-cmake-modules) with some tweaks from [this PR](aminosbh/sdl2-cmake-modules#3).
iplanetcn
pushed a commit
to iplanetcn/sdl2-cmake-modules
that referenced
this pull request
Jun 12, 2023
…mpatibility Config mode and sdl compatibility
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.