Skip to content

Added function to add new line.#53

Open
nxiss7 wants to merge 3 commits intoamiremohamadi:masterfrom
nxiss7:master
Open

Added function to add new line.#53
nxiss7 wants to merge 3 commits intoamiremohamadi:masterfrom
nxiss7:master

Conversation

@nxiss7
Copy link
Copy Markdown

@nxiss7 nxiss7 commented Mar 8, 2020

I think adding new lines is a common task, it's a must-have feature for me.

@amiremohamadi
Copy link
Copy Markdown
Owner

Thank You for the PR!

I think it would be better to define new_line as a constant.
refer to python-docx library, we can define an enum/class (e.g BREAK) that has a value called LINE. So user can add a new line break like this:

p.add_run(duckx::BREAK::LINE);

Feel free to send PRs :)

@nxiss7
Copy link
Copy Markdown
Author

nxiss7 commented Mar 9, 2020

Ok, will take look and update code.
:D

@nxiss7
Copy link
Copy Markdown
Author

nxiss7 commented Mar 27, 2020

After a few busy weeks I could finally refactor the code.
I also added support for columns and tab character too.

@SimantoR
Copy link
Copy Markdown

SimantoR commented Jan 1, 2023

This PR seems ready to be merged in. Any tests to add or verify for this?

@amiremohamadi
Copy link
Copy Markdown
Owner

This PR seems ready to be merged in. Any tests to add or verify for this?

Hi @SimantoR, it seems ready but after completing #81 this will be merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants