Skip to content

Comments

[pull] main from forem:main#74

Merged
pull[bot] merged 5 commits intoamishakov:mainfrom
forem:main
Sep 8, 2025
Merged

[pull] main from forem:main#74
pull[bot] merged 5 commits intoamishakov:mainfrom
forem:main

Conversation

@pull
Copy link

@pull pull bot commented Sep 8, 2025

See Commits and Changes for more details.


Created by pull[bot] (v2.0.0-alpha.3)

Can you help keep this open source service alive? 💖 Please sponsor : )

Siddhant-K-code and others added 5 commits September 8, 2025 10:09
…22307)

* fix: configure devcontainer for Ona environment

- Add network host mode to devcontainer for proper networking
- Enable privileged mode for container operations
- Configure docker-compose with host networking
- Clean up trailing whitespace in verify-setup script

Co-authored-by: Ona <no-reply@ona.com>

* refactor: improve network configuration for all services

- Remove runArgs network config from devcontainer.json
- Add host networking to postgres and redis services
- Reorganize devcontainer network_mode placement for consistency

Co-authored-by: Ona <no-reply@ona.com>

---------

Co-authored-by: Ona <no-reply@ona.com>
* Iframe rendering tweak

* Initial futzing
- Test valid timeframe returns ISO8601 formatted string
- Test latest timeframe returns nil (not a datetime object)
- Test invalid timeframe returns nil
- Follows existing test patterns with Timecop.freeze

Co-authored-by: Ona <no-reply@ona.com>
- Implement 2 retry attempts before falling back to no_moderation_label
- Add comprehensive logging for retry attempts and failures
- Include tests for all retry scenarios and logging behavior
- Maintain existing fallback behavior after exhausting retries

Co-authored-by: Ona <no-reply@ona.com>
- Add dynamic shuffle count calculation based on user's most recent page view
- Shuffle count ranges from 5 (default) to 20 based on recency:
  * Within 1 hour: shuffle top 20 articles
  * 2 hours ago: shuffle top 18 articles
  * Decreases by 1 for each additional hour
  * Minimum of 5 articles (original behavior)
- Apply recent_page_views_shuffle_weight multiplier to calculated count
- Only activate dynamic behavior when recent_page_views_shuffle_weight > 0
- Add comprehensive test coverage for all scenarios and edge cases
- Include recent_page_views_shuffle_weight in FeedConfig clone method
- Maintain backward compatibility with existing shuffle behavior

This enhances user engagement by providing more variety in article ordering
for recently active users while preserving the original experience for
inactive users or when the feature is disabled.

Co-authored-by: Ona <no-reply@ona.com>
@pull pull bot locked and limited conversation to collaborators Sep 8, 2025
@pull pull bot added the ⤵️ pull label Sep 8, 2025
@pull pull bot merged commit 1b4294e into amishakov:main Sep 8, 2025
1 of 2 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants