feat: add SHA-3 (Keccak) hashing support (#2) - #45
Closed
saurav-codes wants to merge 2 commits into
Closed
Conversation
CryptoJS.SHA3 returns Keccak padding, not the NIST SHA-3 standard. Swap to js-sha3 (CDN) so the empty string hashes to a7ffc6f8bf1ed76651c14756a061d662f580ff4de43b49fa82d80a4b80f8434a on both the table and exported PDF.
Author
|
Review was right: CryptoJS.SHA3 returns Keccak padding, not the NIST SHA-3 standard. I swapped it for js-sha3 (sha3_256) over CDN and named the column plain SHA-3. Checked in a node:24 container: empty input hashes to a7ffc6f8bf1ed76651c14756a061d662f580ff4de43b49fa82d80a4b80f8434a, and the inline script still parses cleanly. Commit is signed and pushed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
/claim #2
Adds SHA-3 column via the existing CryptoJS dependency (CryptoJS.SHA3, 256-bit). Included in CSV, PDF, and Word exports. Adds an on-page System Console that logs each SHA-3 calculation, as requested in the issue.