Skip to content

Feature Update: Unit Tests, Ticket Sorting, View Template Addons, Fault Tolerant Commands #54

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 53 commits into
base: master
Choose a base branch
from
Open

Feature Update: Unit Tests, Ticket Sorting, View Template Addons, Fault Tolerant Commands #54

wants to merge 53 commits into from

Conversation

Auwate
Copy link

@Auwate Auwate commented Apr 9, 2024

For a full description, please check the README.md file under recent changes.

Auwate added 30 commits March 20, 2024 15:05
@Auwate
Align with fork repo
b31cce1
@Auwate
Updated settings-dev.py to turn HTTPS off (FOR PRODUCTION)
74d43d8
@Auwate
Changes:
74baa0f 
Added UTC-5 | North America/New York to template
@Auwate
PRODUCTION CHANGE:
686f960 
COMMENTED OUT LOGGING DRIVER
@Auwate
ADDED README AND DEV_TIPS
e46544d
@Auwate
CHANGES:
037ea75 
Dockerfile clone location changed to development.
@Auwate
CHANGES:
88e1f2f 
Testing new ordering based on when the Ticket began, rather than when it ended.
@Auwate
Changes:
5963cea 
Working on ordering.
@Auwate
Changes:
3ddb08d 
- UTC & Ordering
@Auwate
Development
672f003
@Auwate
-
3adddb8
@Auwate
-
214a4b1
@Auwate
Changes:
10e7062 
1: Edited template HTML to include UTC-05:00

2: Editing admin.py to order Tickets by recency, rather than when it ended.

3: Added labels to forms.py
@Auwate
Merged changes
c508bf1
@Auwate
Removed UTC fields from admin.py and models.py
8b3e69a
@Auwate
CHANGES - Sorting | Added action_notes
b4bbfa2
@Auwate
CHANGES:
e2d7f61 
Edit: models.py, views.py

Added a description function to TicketLog. This function simply checks if action_notes exists, and if it does it formats it from HTML.
@Auwate
CHANGES:
ef84c01 
- Edit: Changed TicketLog.description() to last_log.description()
@Auwate
CHANGES:
03c4839 
Edit: added description.allow_tags = True.
@Auwate
Minor Change
f71c667
@Auwate
Minor changes
c9c6f46
@Auwate
Added functionality:
7d81895 
Latest Update now has a time associated with it.
@Auwate
Minor change
4d52c6b
@Auwate
Edited labels to show what each mean.
e66c374
@Auwate
CHANGE
68799b3 
Changed footer CSS from relative to fixed.
@Auwate
MAJOR CHANGE:
4e9a385 
ADDED CLASS TO DIV ON LINE 209.

ADDED CSS PROPERTIES TO .row
@Auwate
Updates to background color
02ec4fe
@Auwate
Removing temporary development to start merging into production.
67e6e94
@Auwate
Added unit test for custom command.
b505509
@Auwate
TEMPORARY COMMIT: TRYING DOCKER TESTING
e23b272
Auwate and others added 22 commits April 1, 2024 16:29
@Auwate
Removing docker-compose test command on startup.
62d1f66
@Auwate
MAJOR COMMIT:
43dca1b 
Unit Tests and a new file: settings-test.py
@Auwate
Updated documentation
2c05c5c
@Auwate
Merge branch 'development'
c0182a8
@Auwate
Update Dockerfile
9461a1b
@Auwate
COMMIT: Updated logging
1c91ea6
@Auwate
Testing Commit: Turning off SESSION_COOKIE_SECURE
9f23c8e
@Auwate
Turned SESSION_COOKIE to True
a9af0e8
@Auwate
Merge branch 'merging'
675fdcb
@Auwate
Merge branch 'master' of https://github.com/Auwate/Services-Status
b51d98c
@Auwate
MAJOR COMMIT: Reducing fluff in merge request.
98fde16 
Includes:
- settings-dev.py
- Delete migrations
- Changing templates and forms to only say UTC
- test-models.py
@Auwate
COMMIT: Fault tolerance by making sure an AttributeError does not occ…
13ea9c0 
…ur when latest_action_notes is checked.

This could cause an error because not all Tickets have logs, and if a Ticket without a log is called, it could raise an error.
@Auwate
COMMIT:
2d93cb8 
Part 1: Reducing fluff

Part 2: Added unit test to check whether the main view (where Tickets are shown), returns a 200 code AND has ticket objects where "latest_action_note" and "latest_action_date" exist.
@Auwate
Update settings-dev.py
824d671 
Align with master repo.
@Auwate
Update settings-dev.py
c8d00ff 
Align with master repo
@Auwate
Update settings-dev.py
e238e57 
Align with master repo
@Auwate
Align with master repo
75f90f0
@Auwate
Update services_status.html
0f91357 
Align with master repo
@Auwate
Update test_models.py
8838a68 
Align with master repo
@Auwate
Update test_models.py
0da35f2 
Align with master repo
@Auwate
Update test_models.py
2d6b081 
Align with master repo
@Auwate
- Commit:
07a3c28 
Fixing unit test
italovalcy
italovalcy requested changes Apr 9, 2024
View reviewed changes
Copy link
Member

@italovalcy italovalcy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Austin, excellent pull request and all changes make sense for me. I just left one comment regarding the GitHub repo used for Dockerfile. Please let me know if you have more information on that.

deploy/Dockerfile Outdated
RUN git clone https://github.com/amlight/Services-Status.git
RUN git clone https://github.com/Auwate/Services-Status.git
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Austin, this particular change here does not seems necessary. Can you please clarify why we need this?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah I was testing using my forked repo, I'll fix that right now!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@italovalcy italovalcy italovalcy requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Auwate @italovalcy