Fix mmkv module jest mock #382
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request updates the interface and mock implementation for removing multiple values from the MMKV memory store. The main changes clarify the function signature for batch removal and ensure the mock reflects the new interface.
API consistency and type safety:
removeValuesMMKVinMMKVJsiModuleto accept an array of keys and anid, instead of a variable argument list, improving clarity and type safety (src/types/index.ts).Mock implementation update:
jest/memoryStore.tsto match the newremoveValuesMMKVsignature, iterating over the provided array of keys and removing each from the memory store.Closes #375