Fix: Junk packets can go in wrong order if device is behind QoS - #144
Open
danpashin wants to merge 1 commit into
Open
Fix: Junk packets can go in wrong order if device is behind QoS#144danpashin wants to merge 1 commit into
danpashin wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
WG handshake packets have
AF41priority while I1-I5 areCS0and JC is arandomvalue. This behaviour can cause handshake to be processed before all other packets on a device with QoS enabled and break junk flow (on the screenshot). Thus TSPU will apply throttling policies to the flow.Fix
Replace invalid DSCP values with
EF(which is more prioritized thanAF41) for junk and leave handshake one (AF41) as is.