fix #40: key length comparison in config.c - #41
Open
miuirussia wants to merge 1 commit into
Open
Conversation
We already have checking emptiness of string in parsers, so empty value is valid Signed-off-by: Kirill Kuznetsov <kdevlab@yandex.ru>
|
Probably it's better to skip lines with empty values in @@ -49,8 +49,10 @@ parse_options() {
shopt -s nocasematch
while read -r line || [[ -n $line ]]; do
stripped="${line%%\#*}"
+ [[ -z "${stripped//[[:space:]]/}" ]] && continue # skip empty lines
key="${stripped%%=*}"; key="${key##*([[:space:]])}"; key="${key%%*([[:space:]])}"
value="${stripped#*=}"; value="${value##*([[:space:]])}"; value="${value%%*([[:space:]])}"
+ [[ $stripped == *"="* && -z "$value" ]] && continue # skip lines with empty values
[[ $key == "["* ]] && interface_section=0
[[ $key == "[Interface]" ]] && interface_section=1
if [[ $interface_section -eq 1 ]]; thenThe reason is we are setting flags for found keys: Lines 580 to 584 in 5d6179a ... and we can set a key unintentionally to an empty string (like |
Author
|
no, not better, as some scripts use directly complied binary, not scripts. and empty PrivateKey will throw exception |
|
I think setting |
Author
|
If you think, so test it and show me cases with error |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We already have checking emptiness of string in parsers, so empty value is valid. Fixes #40