[CHERRY-PICK] wg-quick: linux: do not unnecessarily set sysctl - #45
Open
texhobeer wants to merge 1 commit into
Open
[CHERRY-PICK] wg-quick: linux: do not unnecessarily set sysctl#45texhobeer wants to merge 1 commit into
texhobeer wants to merge 1 commit into
Conversation
In some restrictive container namespaces, sysctl is locked down and can't be changed. This shouldn't be a problem, though, at least in theory, because net.ipv4.conf.all.src_valid_mark is already 1. However, currently wg-quick unconditionally sets it. Instead, check to see if it's already 1 before trying make it 1. Suggested-by: Dean P <dean@apakossa.org> Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found a bug in some scenario while using docker. There is a fix in original WG-Quick repo for it already. TBH, I don't know the sync process of the repo, probably the maintainers are going to update the repo in the nearest future... Anyway, PTAL
--- Original commit comment ---
In some restrictive container namespaces, sysctl is locked down and can't be changed. This shouldn't be a problem, though, at least in theory, because net.ipv4.conf.all.src_valid_mark is already 1. However, currently wg-quick unconditionally sets it. Instead, check to see if it's already 1 before trying make it 1.
Suggested-by: Dean P dean@apakossa.org