Skip to content

feat(glazewm_workspaces): add active label#249

Merged
amnweb merged 2 commits into
amnweb:mainfrom
szbmrk:feat-glazewm-workspaces-active-label
May 5, 2025
Merged

feat(glazewm_workspaces): add active label#249
amnweb merged 2 commits into
amnweb:mainfrom
szbmrk:feat-glazewm-workspaces-active-label

Conversation

@szbmrk

@szbmrk szbmrk commented May 4, 2025

Copy link
Copy Markdown
Contributor

Implements feature requested in #137 .

@Video-Nomad

Video-Nomad commented May 5, 2025

Copy link
Copy Markdown
Contributor

Now that I look at the code I remember why I left only two states there (populated and empty).
Because it was either two like we have now, or four:

  1. active_populated
  2. active_empty
  3. populated
  4. empty

Makes sense I hope? And that's also what @NoePfister mentioned in #137 I think. Correct me if I'm wrong.

@szbmrk

szbmrk commented May 5, 2025

Copy link
Copy Markdown
Contributor Author

Okay i see why we need four, the naming of the labels are a bit more understandable now.

@szbmrk szbmrk force-pushed the feat-glazewm-workspaces-active-label branch from bfb1538 to 01b5cb5 Compare May 5, 2025 06:59

@Video-Nomad Video-Nomad left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@NoePfister

Copy link
Copy Markdown

Thank You👍

@amnweb amnweb merged commit eed7ecc into amnweb:main May 5, 2025
@szbmrk szbmrk deleted the feat-glazewm-workspaces-active-label branch May 6, 2025 06:19
trimclain added a commit to trimclain/yasb that referenced this pull request May 8, 2025
PR amnweb#249 added labels `active_populated` and `active_empty`,
however the CSS classes for them for not updated.
This commit adds missing classes and removes obsolete ones.
Kepners pushed a commit to Kepners/yasb that referenced this pull request Feb 4, 2026
…ive-label

feat(glazewm_workspaces): add `active label`
Kepners pushed a commit to Kepners/yasb that referenced this pull request Feb 4, 2026
PR amnweb#249 added labels `active_populated` and `active_empty`,
however the CSS classes for them for not updated.
This commit adds missing classes and removes obsolete ones.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants