ci: fix ci error - #288
Conversation
|
Note Gemini is unable to generate a summary for this pull request due to the file types involved not being currently supported. |
|
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a CI error by commenting out the vercel-org-id parameter in the GitHub workflow configuration. The change addresses an issue where the Vercel organization ID parameter was causing workflow failures.
- Commented out
vercel-org-idparameter in two deployment jobs - Maintained all other Vercel configuration parameters
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| github-token: ${{ secrets.GITHUB_TOKEN }} | ||
| vercel-token: ${{ secrets.VERCEL_TOKEN }} | ||
| vercel-org-id: ${{ secrets.VERCEL_ORG_ID }} | ||
| # vercel-org-id: ${{ secrets.VERCEL_ORG_ID }} |
There was a problem hiding this comment.
Instead of commenting out the parameter, consider either removing it entirely if it's no longer needed, or add a comment explaining why it's temporarily disabled and under what conditions it should be re-enabled.
| github-token: ${{ secrets.GITHUB_TOKEN }} | ||
| vercel-token: ${{ secrets.VERCEL_TOKEN }} | ||
| vercel-org-id: ${{ secrets.VERCEL_ORG_ID }} | ||
| # vercel-org-id: ${{ secrets.VERCEL_ORG_ID }} |
There was a problem hiding this comment.
Instead of commenting out the parameter, consider either removing it entirely if it's no longer needed, or add a comment explaining why it's temporarily disabled and under what conditions it should be re-enabled.
|
Deploy preview for team-scope-test ready! ✅ Preview Built with commit 66260cb. |
|
Deploy preview for express-basic-auth ready! ✅ Preview Built with commit 52be3ad. |
Code Review FeedbackSummaryThis PR comments out the ✅ Positive Aspects
🔍 AnalysisCode Quality: ✅ Good
Potential Issues:
Security: ✅ No concerns
Performance: ✅ No impact
🤔 Questions & Recommendations
📋 Testing ConsiderationsThe change appears safe since:
🎯 Final AssessmentApproval Status: ✅ Approved with minor suggestions This is a valid fix that follows project conventions. The change is minimal and appears to address a specific CI issue. However, adding context about the error and ensuring consistency across examples would improve the overall solution. Generated with Claude Code |
66260cb to
211d778
Compare
Vercel CLI now rejects personal accounts as scope, causing "You cannot set your Personal Account as the scope" errors. Remove vercel-org-id from workflows using VERCEL_ORG_ID (personal account). Also fix Angular build OpenSSL compatibility issue.
The test.yml workflow uses amondnet/now-deployment@v2.0.3 which relies on the deprecated set-env command, causing CI failures.
|



No description provided.