Skip to content

ci: fix ci error - #288

Merged
amondnet merged 3 commits into
masterfrom
ci-fix-example-static
Mar 25, 2026
Merged

ci: fix ci error#288
amondnet merged 3 commits into
masterfrom
ci-fix-example-static

Conversation

@amondnet

Copy link
Copy Markdown
Owner

No description provided.

Copilot AI review requested due to automatic review settings August 29, 2025 01:43
@gemini-code-assist

Copy link
Copy Markdown
Contributor

Note

Gemini is unable to generate a summary for this pull request due to the file types involved not being currently supported.

@sonarqubecloud

Copy link
Copy Markdown

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes a CI error by commenting out the vercel-org-id parameter in the GitHub workflow configuration. The change addresses an issue where the Vercel organization ID parameter was causing workflow failures.

  • Commented out vercel-org-id parameter in two deployment jobs
  • Maintained all other Vercel configuration parameters

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Comment thread .github/workflows/example-static.yml Outdated
github-token: ${{ secrets.GITHUB_TOKEN }}
vercel-token: ${{ secrets.VERCEL_TOKEN }}
vercel-org-id: ${{ secrets.VERCEL_ORG_ID }}
# vercel-org-id: ${{ secrets.VERCEL_ORG_ID }}

Copilot AI Aug 29, 2025

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of commenting out the parameter, consider either removing it entirely if it's no longer needed, or add a comment explaining why it's temporarily disabled and under what conditions it should be re-enabled.

Copilot uses AI. Check for mistakes.
Comment thread .github/workflows/example-static.yml Outdated
github-token: ${{ secrets.GITHUB_TOKEN }}
vercel-token: ${{ secrets.VERCEL_TOKEN }}
vercel-org-id: ${{ secrets.VERCEL_ORG_ID }}
# vercel-org-id: ${{ secrets.VERCEL_ORG_ID }}

Copilot AI Aug 29, 2025

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of commenting out the parameter, consider either removing it entirely if it's no longer needed, or add a comment explaining why it's temporarily disabled and under what conditions it should be re-enabled.

Copilot uses AI. Check for mistakes.
@github-actions

Copy link
Copy Markdown
Contributor

Deploy preview for team-scope-test ready!

✅ Preview
https://team-scope-test-a1ro8q6ow-dietfriends.vercel.app

Built with commit 66260cb.
This pull request is being automatically deployed with vercel-action

@github-actions

github-actions Bot commented Aug 29, 2025

Copy link
Copy Markdown
Contributor

Deploy preview for express-basic-auth ready!

✅ Preview
https://express-basic-auth-nu6bx8vkr-minsu-lees-projects-b1e388b7.vercel.app

Built with commit 52be3ad.
This pull request is being automatically deployed with vercel-action

@claude

claude Bot commented Aug 29, 2025

Copy link
Copy Markdown

Code Review Feedback

Summary

This PR comments out the vercel-org-id parameter in the example-static.yml workflow to fix a CI error. The change is minimal and focused, which aligns with the project's best practices.

✅ Positive Aspects

  1. Small, Focused Change: The PR follows the "small, safe change" principle outlined in AGENTS.md
  2. Consistent Pattern: The change is applied consistently to both staging and production deployment steps
  3. Descriptive Title: The commit title "ci: fix ci error" follows the conventional commit format

🔍 Analysis

Code Quality: ✅ Good

  • Clean, simple change that doesn't introduce complexity
  • Preserves existing workflow structure and logic

Potential Issues: ⚠️ Some concerns

  • Missing Context: The PR description is empty - it would be helpful to understand what specific CI error this fixes
  • Inconsistency with Other Workflows: Other example workflows (nextjs, team-scope) still use vercel-org-id - this creates inconsistency across examples

Security: ✅ No concerns

  • Change only affects example workflows
  • No secrets or credentials exposed
  • No new attack vectors introduced

Performance: ✅ No impact

  • No performance implications from this change

🤔 Questions & Recommendations

  1. Root Cause: What specific error was occurring? Understanding this would help determine if this is the right fix or if other workflows need similar updates.

  2. Consistency: Should other example workflows be updated similarly? The nextjs and team-scope examples still use vercel-org-id.

  3. Documentation: Consider adding a brief explanation in the PR description about why vercel-org-id is being removed.

  4. Action.yml Reference: According to action.yml:28-30, vercel-org-id is optional and used for "Vercel CLI 17+". The index.js code (lines 101-104) shows it's only set as an environment variable if provided. This suggests the change should be safe.

📋 Testing Considerations

The change appears safe since:

  • vercel-org-id is optional per the action definition
  • The core action handles missing org ID gracefully
  • Other workflows function without explicit org ID parameter

🎯 Final Assessment

Approval Status: ✅ Approved with minor suggestions

This is a valid fix that follows project conventions. The change is minimal and appears to address a specific CI issue. However, adding context about the error and ensuring consistency across examples would improve the overall solution.


Generated with Claude Code

@amondnet amondnet self-assigned this Mar 25, 2026
@amondnet
amondnet force-pushed the ci-fix-example-static branch from 66260cb to 211d778 Compare March 25, 2026 21:50

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 1 file

Requires human review: Modifies a CI/CD workflow configuration, which is a high-impact change requiring human review according to the guidelines.

Vercel CLI now rejects personal accounts as scope, causing
"You cannot set your Personal Account as the scope" errors.
Remove vercel-org-id from workflows using VERCEL_ORG_ID (personal
account). Also fix Angular build OpenSSL compatibility issue.
The test.yml workflow uses amondnet/now-deployment@v2.0.3 which relies
on the deprecated set-env command, causing CI failures.
@sonarqubecloud

Copy link
Copy Markdown

@amondnet
amondnet merged commit 5d88157 into master Mar 25, 2026
8 of 15 checks passed
@amondnet
amondnet deleted the ci-fix-example-static branch March 25, 2026 22:00

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

0 issues found across 5 files (changes from recent commits).

Requires human review: Modifies CI/CD workflows and Vercel deployment configurations, including removing an entire test workflow and environment variables.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants