Skip to content

Issues/0168 valgrind issue ctlrender with unsupported input format #179

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
michaeldsmith merged 2 commits into from
Mar 13, 2025
Merged

Issues/0168 valgrind issue ctlrender with unsupported input format #179

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
18f4bcd
setup CI to run valgrind without libtiff
michaeldsmith Mar 12, 2025
d3c029f
use different exit code to differentiate valgrind memory error exit c…
michaeldsmith Mar 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions .github/workflows/docker_linuxes.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -213,3 +213,14 @@ jobs:

- name: Run unit tests (ctest) within the Docker image
run: docker run ctl:latest sh -c "cd ./build && ctest"

ubuntu-22-04-no-libtiff-valgrind:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
- name: Build the Docker image
run: docker build --no-cache --rm -f ./docker/Dockerfile_ubuntu_22.04_no_libtiff_valgrind -t ctl:latest .

- name: Run the docker that runs valgrind
run: docker run ctl:latest

33 changes: 33 additions & 0 deletions docker/Dockerfile_ubuntu_22.04_no_libtiff_valgrind
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,33 @@
FROM ubuntu:22.04

RUN apt-get update

# disable interactive install
ENV DEBIAN_FRONTEND noninteractive

# install developement tools
RUN apt-get -y install cmake
RUN apt-get -y install g++

# install developement debugging tools
RUN apt-get -y install valgrind

# install CTL dependencies
RUN apt-get -y install libopenexr-dev
#RUN apt-get -y install libtiff-dev

# build CTL
WORKDIR /usr/src/CTL
COPY . .
WORKDIR /usr/src/CTL/build
RUN rm -R * || true
RUN cmake .. -DCMAKE_BUILD_TYPE=Debug
RUN make
RUN make install

# finalize docker environment
WORKDIR /usr/src/CTL/build

# run valgrind
CMD bash /usr/src/CTL/resources/test/scripts/run_valgrind.sh

Loading
Loading