fix: Resolve custom illuminant crash and add advanced CLF controls #122
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit resolves critical bugs in the custom illuminant workflow and addresses several issues in the camera calculator UI. - A complete fix for the "Custom" illuminant handling. The application no longer crashes when "Custom" is selected. It now correctly processes and utilizes the user-provided spectral power distribution (SPD) throughout the calculation pipeline. - Corrected the white point calculation method for custom illuminant SPDs in `aces/idt/core/common.py`. - Fixed a series of bugs in the `idt_calculator_camera` application where parameters from the web UI (e.g., `RGB_display_colourspace`, `optimisation_space`, `LUT Size`) were not being properly received or processed by the backend. - Resolved an image caching issue that prevented analysis images (like `colour_checker_segmentation`) from displaying on subsequent calculations. - Added debugging logs for CLF generation options and the final transformation matrix to aid future development. feat: Add advanced controls for CLF generation Added three new boolean toggles to the camera calculator UI to provide more granular control over the generated CLF file: - `Flatten CLF` - `Include White Balance in CLF` - `Include Exposure Factor in CLF`
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses a critical crash related to custom illuminant handling and resolves several bugs within the camera calculator. It also introduces new, advanced controls for CLF generation to provide users with more flexibility.
Summary of Changes
This pull request contains two main categories of changes: bug fixes and new features.
Bug Fixes
aces/idt/core/common.py.idt_calculator_camerawhere parameters set in the UI (such asRGB_display_colourspace,optimisation_space, andLUT Size) were not being correctly transmitted to or processed by the backend.colour_checker_segmentation) from being displayed correctly on subsequent calculations.New Features
Flatten CLFInclude White Balance in CLFInclude Exposure Factor in CLF