Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1416 +/- ##
==========================================
- Coverage 94.34% 94.33% -0.02%
==========================================
Files 99 99
Lines 796 794 -2
==========================================
- Hits 751 749 -2
Misses 45 45
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Nytelife26
requested changes
Sep 2, 2025
Contributor
Nytelife26
left a comment
Nytelife26
left a comment
There was a problem hiding this comment.
Looks good so far, other than this one detail.
Merged
This was referenced Sep 2, 2025
they seem to build a lot since uv2nix
This reverts commit 3cb40b9.
Nytelife26
reviewed
Sep 8, 2025
Contributor
Nytelife26
left a comment
Nytelife26
left a comment
There was a problem hiding this comment.
This looks great. Thank you for all the hard work! Hopefully the tokens work correctly when the changes land on main, but if not I'll be able to troubleshoot that. After the pull_request trigger and # TODO: Notify are removed, I can approve this if you have nothing left to do.
Nytelife26
requested changes
Sep 8, 2025
Nytelife26
approved these changes
Sep 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1382.