feat: override keys and dot-prop#1440
Merged
Nytelife26 merged 19 commits intoamperser:mainfrom Oct 6, 2025
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1440 +/- ##
==========================================
- Coverage 94.28% 94.19% -0.09%
==========================================
Files 99 99
Lines 805 810 +5
==========================================
+ Hits 759 763 +4
- Misses 46 47 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Nytelife26
added a commit
that referenced
this pull request
Oct 3, 2025
As @drainpixie noticed in #1440, checking segment sequences is equivalent to asking if the raw path starts with the partial key followed by the delimiter. This greatly improves the performance of matches_partial in the fallback case (3x on my system). Co-authored-by: drainpixie <121581793+drainpixie@users.noreply.github.com>
Nytelife26
requested changes
Oct 3, 2025
Contributor
Nytelife26
left a comment
Nytelife26
left a comment
There was a problem hiding this comment.
I love the overall simplicity of your solution here. Good work.
Nytelife26
requested changes
Oct 3, 2025
Contributor
Nytelife26
left a comment
Nytelife26
left a comment
There was a problem hiding this comment.
Minor documentation changes, and then we're good to go.
Co-authored-by: Tyler J Russell <xtylerjrx@gmail.com> Signed-off-by: drainpixie <121581793+drainpixie@users.noreply.github.com>
Co-authored-by: Tyler J Russell <xtylerjrx@gmail.com> Signed-off-by: drainpixie <121581793+drainpixie@users.noreply.github.com>
Co-authored-by: Tyler J Russell <xtylerjrx@gmail.com> Signed-off-by: drainpixie <121581793+drainpixie@users.noreply.github.com>
Nytelife26
requested changes
Oct 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relevant issues
#1375
Brief
Make it possible to disable checks without too much repetition, e.g. instead of writing
{ "typography.symbols.ellipsis": false, "typography.symbols.curly_quotes": false }You're now able to
{ "typography.symbols": { "ellipsis": false, "curly_quotes": false } }And support overriding keys like such:
{ "typography": true, "typography.symbols": false, "typography.symbols.curly_quotes": true, "typography.punctuation.hyperbole": false }Changes
config.pyget_all_enabled