Skip to content

perf(registry): early exit matches_partial #1441

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Nytelife26 merged 2 commits into from
Oct 3, 2025
Merged

perf(registry): early exit matches_partial #1441

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
25034b2
perf(registry): early exit matches_partial
Nytelife26 Oct 2, 2025
4a06fb5
perf: use startswith for fallback in matches_partial
Nytelife26 Oct 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions proselint/registry/checks/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,9 +145,7 @@ def path_segments(self) -> list[str]:

def matches_partial(self, partial: str) -> bool:
"""Check if `partial` is a subset key of the full check path."""
partial_segments = partial.split(".")

return self.path_segments[: len(partial_segments)] == partial_segments
return self.path == partial or self.path.startswith(f"{partial}.")

def check(self, text: str) -> Iterator[CheckResult]:
"""Apply the check over `text`."""
Expand Down