Skip to content

refactor: stabilise wire logging#1444

Merged
Nytelife26 merged 13 commits intomainfrom
refactor/logging
Nov 11, 2025
Merged

refactor: stabilise wire logging#1444
Nytelife26 merged 13 commits intomainfrom
refactor/logging

Conversation

@Nytelife26
Copy link
Copy Markdown
Contributor

@Nytelife26 Nytelife26 commented Oct 28, 2025

Relevant issues

Resolves #1427.

Brief

Implement stable infallible JSON logging for Proselint.

Changes

  • Move OutputFormat to proselint.log
  • Use correct output streams for log levels
  • Move LintResult to proselint.tools
  • Introduce infallible JSON logging
  • Use span and pos in CheckResult and LintResult

Credits

@jclicodes for greatly helping with authoring and refining the wire specification.

@Nytelife26 Nytelife26 added the type: refactor A change that does not fix a bug or add a feature label Oct 28, 2025
@suchow suchow requested review from Copilot and removed request for Copilot October 29, 2025 22:58
@Nytelife26 Nytelife26 marked this pull request as ready for review November 11, 2025 18:51
@Nytelife26 Nytelife26 requested a review from suchow as a code owner November 11, 2025 18:51
@codecov
Copy link
Copy Markdown

codecov bot commented Nov 11, 2025

Codecov Report

❌ Patch coverage is 65.06849% with 51 lines in your changes missing coverage. Please review.
✅ Project coverage is 91.12%. Comparing base (e12a943) to head (8af2cc9).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
proselint/log.py 59.55% 36 Missing ⚠️
proselint/command_line.py 55.00% 9 Missing ⚠️
proselint/tools.py 82.85% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1444      +/-   ##
==========================================
- Coverage   94.19%   91.12%   -3.08%     
==========================================
  Files         100      100              
  Lines         948     1037      +89     
==========================================
+ Hits          893      945      +52     
- Misses         55       92      +37     
Flag Coverage Δ
macos-latest 90.54% <65.06%> (-3.02%) ⬇️
py3.10 91.12% <65.06%> (-3.08%) ⬇️
py3.11 91.12% <65.06%> (-3.08%) ⬇️
py3.12 91.12% <65.06%> (-3.08%) ⬇️
py3.13 90.54% <65.06%> (-3.02%) ⬇️
py3.14 90.54% <65.06%> (-3.02%) ⬇️
ubuntu-latest 90.54% <65.06%> (-3.02%) ⬇️
windows-latest 91.12% <65.06%> (-3.08%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Nytelife26 Nytelife26 merged commit 02e85a8 into main Nov 11, 2025
40 of 50 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type: refactor A change that does not fix a bug or add a feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[rfc] stabilised wire output for proselint

2 participants