Skip to content

refactor(config)!: stop searching after file is found#1474

Merged
Nytelife26 merged 1 commit intomainfrom
refactor/config-search
Jan 26, 2026
Merged

refactor(config)!: stop searching after file is found#1474
Nytelife26 merged 1 commit intomainfrom
refactor/config-search

Conversation

@Nytelife26
Copy link
Copy Markdown
Contributor

Relevant issues

Blocked by #1473. Resolves an objective of #1375.

Brief

This removes the implicit merging behaviour, instead searching the paths and stopping at the first instance of a usable config, or falling back to the default.

Changes

  • Reverse priorities of proselint.config.config_paths
  • Remove implicit merging from proselint.config.load_from

@Nytelife26 Nytelife26 added type: refactor A change that does not fix a bug or add a feature version: breaking PRs with breaking changes, requiring a major release labels Jan 12, 2026
@codecov
Copy link
Copy Markdown

codecov bot commented Jan 12, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.62%. Comparing base (1f4c0eb) to head (881a99a).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1474   +/-   ##
=======================================
  Coverage   92.62%   92.62%           
=======================================
  Files         100      100           
  Lines        1017     1017           
=======================================
  Hits          942      942           
  Misses         75       75           
Flag Coverage Δ
macos-latest 92.03% <100.00%> (ø)
py3.10 92.62% <100.00%> (ø)
py3.11 92.62% <100.00%> (ø)
py3.12 92.62% <100.00%> (ø)
py3.13 92.03% <100.00%> (ø)
py3.14 92.03% <100.00%> (ø)
ubuntu-latest 92.03% <100.00%> (ø)
windows-latest 92.62% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

BREAKING CHANGE:

This removes the previous implicit merging behaviour. Configuration that
relied on this behaviour will need to be modified to include the
merged-in values.
@Nytelife26 Nytelife26 force-pushed the refactor/config-search branch from 2eaab85 to 881a99a Compare January 20, 2026 13:18
@Nytelife26 Nytelife26 marked this pull request as ready for review January 20, 2026 13:26
@Nytelife26 Nytelife26 requested a review from suchow as a code owner January 20, 2026 13:26
@Nytelife26 Nytelife26 requested a review from drainpixie January 20, 2026 13:26
@Nytelife26 Nytelife26 merged commit 92816e1 into main Jan 26, 2026
34 checks passed
@Nytelife26 Nytelife26 deleted the refactor/config-search branch January 26, 2026 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type: refactor A change that does not fix a bug or add a feature version: breaking PRs with breaking changes, requiring a major release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants