fix: pre-commit hook file type filter#1477
Merged
Nytelife26 merged 1 commit intoamperser:mainfrom Jan 16, 2026
Merged
Conversation
Nytelife26
approved these changes
Jan 16, 2026
drainpixie
approved these changes
Jan 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relevant issues
In #1465, I only did a manual test for the initial commit, but not for subsequent ones. This way, I broke the file filter and now, the hook doesn't apply to any file, but just skips all of them. For example for a markdown file:
Brief
Fix the pre-commit hook to apply to any of the listed file types.
Changes
same as brief. With this change, I get
So the hook applies to the correct files again.
Why did this break? Because of this logic:
So the hook tried to find files that are simultaneously markdown, html, txt, and tex. In contrast to this,
So that's the field we want to set.