Skip to content

Commit

Permalink
Merge pull request #404 from amplication/feat/ra-graphql-upgrade
Browse files Browse the repository at this point in the history
Feat/ra graphql upgrade
  • Loading branch information
mulygottlieb authored Sep 16, 2024
2 parents a9e1d36 + e2a864b commit 856a6d6
Show file tree
Hide file tree
Showing 25 changed files with 271 additions and 699 deletions.
8 changes: 4 additions & 4 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion plugins/auth-auth0/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@amplication/plugin-auth-auth0",
"version": "1.0.14",
"version": "1.0.16",
"description": "Auth0 plugin for Amplication",
"main": "dist/index.js",
"scripts": {
Expand Down
12 changes: 6 additions & 6 deletions plugins/auth-auth0/src/events/createAdminDotEnv.ts
Original file line number Diff line number Diff line change
Expand Up @@ -52,12 +52,12 @@ export const beforeCreateAdminDotEnv = async (

const envVariables = {
// Auth0
REACT_APP_AUTH0_DOMAIN: domain,
REACT_APP_AUTH0_CLIENT_ID: clientID,
REACT_APP_AUTH0_AUDIENCE: audience,
REACT_APP_AUTH0_REDIRECT_URI: "http://localhost:3001/auth-callback",
REACT_APP_AUTH0_LOGOUT_REDIRECT_URI: "http://localhost:3001/login",
REACT_APP_AUTH0_SCOPE: "openid profile email",
VITE_REACT_APP_AUTH0_DOMAIN: domain,
VITE_REACT_APP_AUTH0_CLIENT_ID: clientID,
VITE_REACT_APP_AUTH0_AUDIENCE: audience,
VITE_REACT_APP_AUTH0_REDIRECT_URI: "http://localhost:3001/auth-callback",
VITE_REACT_APP_AUTH0_LOGOUT_REDIRECT_URI: "http://localhost:3001/login",
VITE_REACT_APP_AUTH0_SCOPE: "openid profile email",
};

eventParams.envVariables = eventParams.envVariables.concat(
Expand Down
100 changes: 0 additions & 100 deletions plugins/auth-auth0/src/static/client/Login.tsx

This file was deleted.

27 changes: 27 additions & 0 deletions plugins/auth-auth0/src/static/client/LoginForm.tsx
Original file line number Diff line number Diff line change
@@ -0,0 +1,27 @@
import * as React from "react";
import { useLogin, useNotify } from "react-admin";
import { Button } from "@mui/material";

const LoginForm = ({ theme }: any) => {
const login = useLogin();
const notify = useNotify();
const submit = (e: React.MouseEvent<HTMLButtonElement>) => {
e.preventDefault();
notify("Redirecting to Auth0");
login({});
};


return (
<Button
type="submit"
variant="contained"
color="primary"
onClick={submit}
>
Log in
</Button>
);
};

export default LoginForm;
Original file line number Diff line number Diff line change
Expand Up @@ -4,11 +4,11 @@ import { AuthProvider, UserIdentity } from "react-admin";
export const PreviousLocationStorageKey = "@react-admin/nextPathname";

export const client = new Auth0Client({
domain: process.env.REACT_APP_AUTH0_DOMAIN || "",
clientId: process.env.REACT_APP_AUTH0_CLIENT_ID || "",
domain: process.env.VITE_REACT_APP_AUTH0_DOMAIN || "",
clientId: process.env.VITE_REACT_APP_AUTH0_CLIENT_ID || "",
cacheLocation: "localstorage",
authorizationParams: {
audience: process.env.REACT_APP_AUTH0_AUDIENCE,
audience: process.env.VITE_REACT_APP_AUTH0_AUDIENCE,
scope: "openid profile email",
},
useRefreshTokens: true,
Expand All @@ -18,7 +18,7 @@ export const auth0AuthProvider: AuthProvider = {
login: async () => {
await client.loginWithPopup({
authorizationParams: {
redirect_uri: process.env.REACT_APP_AUTH0_REDIRECT_URI,
redirect_uri: process.env.VITE_REACT_APP_AUTH0_REDIRECT_URI,
},
});

Expand All @@ -28,7 +28,7 @@ export const auth0AuthProvider: AuthProvider = {
logout: async () => {
await client.logout({
logoutParams: {
returnTo: process.env.REACT_APP_AUTH0_LOGOUT_REDIRECT_URI,
returnTo: process.env.VITE_REACT_APP_AUTH0_LOGOUT_REDIRECT_URI,
},
});

Expand Down
34 changes: 22 additions & 12 deletions plugins/auth-auth0/src/tests/createAdminDotEnv.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -26,12 +26,17 @@ describe("Testing beforeCreateAdminDotEnv hook", () => {
eventParams = await beforeCreateAdminDotEnv(context, eventParams);

const expectedEnvVariables = [
{ REACT_APP_AUTH0_DOMAIN: "AUTH0_DOMAIN" },
{ REACT_APP_AUTH0_CLIENT_ID: "AUTH0_CLIENT_ID" },
{ REACT_APP_AUTH0_AUDIENCE: "AUTH0_AUDIENCE" },
{ REACT_APP_AUTH0_REDIRECT_URI: "http://localhost:3001/auth-callback" },
{ REACT_APP_AUTH0_LOGOUT_REDIRECT_URI: "http://localhost:3001/login" },
{ REACT_APP_AUTH0_SCOPE: "openid profile email" },
{ VITE_REACT_APP_AUTH0_DOMAIN: "AUTH0_DOMAIN" },
{ VITE_REACT_APP_AUTH0_CLIENT_ID: "AUTH0_CLIENT_ID" },
{ VITE_REACT_APP_AUTH0_AUDIENCE: "AUTH0_AUDIENCE" },
{
VITE_REACT_APP_AUTH0_REDIRECT_URI:
"http://localhost:3001/auth-callback",
},
{
VITE_REACT_APP_AUTH0_LOGOUT_REDIRECT_URI: "http://localhost:3001/login",
},
{ VITE_REACT_APP_AUTH0_SCOPE: "openid profile email" },
];

expect(eventParams.envVariables).toEqual(expectedEnvVariables);
Expand All @@ -47,12 +52,17 @@ describe("Testing beforeCreateAdminDotEnv hook", () => {
eventParams = await beforeCreateAdminDotEnv(context, eventParams);

const expectedEnvVariables = [
{ REACT_APP_AUTH0_DOMAIN: "CUSTOM_AUTH0_DOMAIN" },
{ REACT_APP_AUTH0_CLIENT_ID: "CUSTOM_AUTH0_CLIENT_ID" },
{ REACT_APP_AUTH0_AUDIENCE: "CUSTOM_AUTH0_AUDIENCE" },
{ REACT_APP_AUTH0_REDIRECT_URI: "http://localhost:3001/auth-callback" },
{ REACT_APP_AUTH0_LOGOUT_REDIRECT_URI: "http://localhost:3001/login" },
{ REACT_APP_AUTH0_SCOPE: "openid profile email" },
{ VITE_REACT_APP_AUTH0_DOMAIN: "CUSTOM_AUTH0_DOMAIN" },
{ VITE_REACT_APP_AUTH0_CLIENT_ID: "CUSTOM_AUTH0_CLIENT_ID" },
{ VITE_REACT_APP_AUTH0_AUDIENCE: "CUSTOM_AUTH0_AUDIENCE" },
{
VITE_REACT_APP_AUTH0_REDIRECT_URI:
"http://localhost:3001/auth-callback",
},
{
VITE_REACT_APP_AUTH0_LOGOUT_REDIRECT_URI: "http://localhost:3001/login",
},
{ VITE_REACT_APP_AUTH0_SCOPE: "openid profile email" },
];

expect(eventParams.envVariables).toEqual(expectedEnvVariables);
Expand Down
2 changes: 1 addition & 1 deletion plugins/auth-keycloak/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@amplication/plugin-auth-keycloak",
"version": "0.0.10",
"version": "0.0.11",
"description": "Keycloak Authentication plugin for Amplication",
"main": "dist/index.js",
"nx": {},
Expand Down
10 changes: 5 additions & 5 deletions plugins/auth-keycloak/src/events/createAdminDotEnv.ts
Original file line number Diff line number Diff line change
Expand Up @@ -7,21 +7,21 @@ import { getPluginSettings } from "../utils/getPluginSettings";

export const beforeCreateAdminDotEnv = async (
context: DsgContext,
eventParams: CreateAdminDotEnvParams,
eventParams: CreateAdminDotEnvParams
): Promise<CreateAdminDotEnvParams> => {
const settings = getPluginSettings(context.pluginInstallations);

const { port, realmID, clientID } = settings;

const envVariables = {
// Keycloak
REACT_APP_KEYCLOAK_URL: `http://localhost:${port}`,
REACT_APP_KEYCLOAK_REALM: realmID,
REACT_APP_KEYCLOAK_CLIENT_ID: clientID,
VITE_REACT_APP_KEYCLOAK_URL: `http://localhost:${port}`,
VITE_REACT_APP_KEYCLOAK_REALM: realmID,
VITE_REACT_APP_KEYCLOAK_CLIENT_ID: clientID,
};

eventParams.envVariables = eventParams.envVariables.concat(
convertToVarDict(envVariables),
convertToVarDict(envVariables)
);

return eventParams;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3,9 +3,9 @@ import { AuthProvider } from "react-admin";
import { jwtDecode } from "jwt-decode";

const keycloakConfig: KeycloakConfig = {
realm: process.env.REACT_APP_KEYCLOAK_REALM || "master",
url: process.env.REACT_APP_KEYCLOAK_URL || "http://localhost:8080/auth",
clientId: process.env.REACT_APP_KEYCLOAK_CLIENT_ID || "admin-ui",
realm: process.env.VITE_REACT_APP_KEYCLOAK_REALM || "master",
url: process.env.VITE_REACT_APP_KEYCLOAK_URL || "http://localhost:8080/auth",
clientId: process.env.VITE_REACT_APP_KEYCLOAK_CLIENT_ID || "admin-ui",
};

export const keycloakClient = new Keycloak(keycloakConfig);
Expand Down
12 changes: 6 additions & 6 deletions plugins/auth-keycloak/src/tests/createAdminDotEnv.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -26,9 +26,9 @@ describe("Testing beforeCreateAdminDotEnv hook", () => {
eventParams = await beforeCreateAdminDotEnv(context, eventParams);

const expectedEnvVariables = [
{ REACT_APP_KEYCLOAK_URL: "http://localhost:8080" },
{ REACT_APP_KEYCLOAK_REALM: "amplication-sample-realm" },
{ REACT_APP_KEYCLOAK_CLIENT_ID: "amplication-server" },
{ VITE_REACT_APP_KEYCLOAK_URL: "http://localhost:8080" },
{ VITE_REACT_APP_KEYCLOAK_REALM: "amplication-sample-realm" },
{ VITE_REACT_APP_KEYCLOAK_CLIENT_ID: "amplication-server" },
];

expect(eventParams.envVariables).toEqual(expectedEnvVariables);
Expand All @@ -43,9 +43,9 @@ describe("Testing beforeCreateAdminDotEnv hook", () => {
eventParams = await beforeCreateAdminDotEnv(context, eventParams);

const expectedEnvVariables = [
{ REACT_APP_KEYCLOAK_URL: "http://localhost:3000" },
{ REACT_APP_KEYCLOAK_REALM: "CUSTOM_KEYCLOAK_REALM_ID" },
{ REACT_APP_KEYCLOAK_CLIENT_ID: "CUSTOM_KEYCLOAK_CLIENT_ID" },
{ VITE_REACT_APP_KEYCLOAK_URL: "http://localhost:3000" },
{ VITE_REACT_APP_KEYCLOAK_REALM: "CUSTOM_KEYCLOAK_REALM_ID" },
{ VITE_REACT_APP_KEYCLOAK_CLIENT_ID: "CUSTOM_KEYCLOAK_CLIENT_ID" },
];

expect(eventParams.envVariables).toEqual(expectedEnvVariables);
Expand Down
2 changes: 1 addition & 1 deletion plugins/auth-saml/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@amplication/plugin-auth-saml",
"version": "1.0.4",
"version": "1.0.5",
"description": "Description of your plugin",
"main": "dist/index.js",
"nx": {},
Expand Down
Loading

0 comments on commit 856a6d6

Please sign in to comment.