feat(plugins): add keycloak plugin #318
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Shurtu-gal do you mind rebasing on master as we just merged a PR that clean all linting/testing issues? |
|
Done @overbit. What about templates, I guess they should also be put in |
|
@Shurtu-gal that is a good point. Can you raise a new PR just for that (eslint ignore in the template)? |
|
Sure. |
overbit
suggested changes
Jan 4, 2024
There was a problem hiding this comment.
@Shurtu-gal really good work. Just a couple of comments but generally looks great
plugins/auth-keycloak/src/templates/jwt.strategy.base.template.ts
Outdated
Show resolved
Hide resolved
|
@overbit The required changes are done. |
overbit
approved these changes
Jan 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: amplication/amplication#7044
PR Details
Add Keycloak plugin for authentication
PR Checklist
npm builddoesn't throw any errornpm testdoesn't throw any errorIMPORTANT: Please review the CONTRIBUTING.md file for detailed contributing guidelines.