fix(android): deviceId now passed as parameter to native Android SDK #282
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aliaksandr-kazarez
approved these changes
Oct 8, 2025
justin-fiedler
pushed a commit
that referenced
this pull request
Oct 9, 2025
## [4.3.8](v4.3.7...v4.3.8) (2025-10-09) ### Bug Fixes * **android:** deviceId now passed as parameter to native Android SDK ([#282](#282)) ([67698ff](67698ff))
|
🎉 This PR is included in version 4.3.8 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The underlying Amplitude-Kotlin supports
deviceIdbeing passed as a parameter as part of theConfigurationobject to setdeviceIdduring initialization. The Flutter SDK plugin did not parse the deviceId and pass it through to the Kotlin SDK, so this did not actually occur.Solution
Grab
deviceIdin getConfiguration method in AmplitudeFlutterPlugin.kt so that it is correctly passed through to Kotlin SDK.Testing
Manually tested that deviceId is now reflected in initialization
Jira: https://amplitude.atlassian.net/browse/AMP-141303
Fixes #281