remove initializerQueue, move db logic from init to initializeApiKey,…#109
Open
remove initializerQueue, move db logic from init to initializeApiKey,…#109
Conversation
… guarded db interactions with apikey check
| _backgroundQueue.name = BACKGROUND_QUEUE_NAME; | ||
|
|
||
| [_initializerQueue addOperationWithBlock:^{ | ||
| [_backgroundQueue addOperationWithBlock:^{ |
Member
There was a problem hiding this comment.
want to make sure here that this is guaranteed to be called before any other _backgroundQueue addOperationWithBlock calls can be made
Member
Author
There was a problem hiding this comment.
I just searched through the code and all addOperationWithBlock and runOnBackgroundQueue calls are protected with an apiKey check, so they need to call initializeApiKey before any of those methods work.
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… guarded db interactions with apikey check
This is part 1 of the database migration work. We need to migrate any database interaction logic in the
initmethod into theinitializeApiKeymethod since we will need the apiKey to interact with the database. I also run theinitlogic on thebackgroundQueue, removing the need for a separateinitializerQueue.Few things to note:
_dbHelperis initialized ininitializeApiKeynow. Any public methods that interact with the database such assetUserId,setDeviceId,identify, etc need to be guarded with an apiKey check to ensure[self.dbHelper]is available[self addObservers]toinitializeApiKeysinceenterBackgroundinteracts with the DB by saving the current timestamp.