Skip to content

Fix: Story Player autoplay and slide advancement issue (#40409)#40421

Open
Vijayshree25 wants to merge 8 commits intoampproject:mainfrom
Vijayshree25:fix-story-player-bug
Open

Fix: Story Player autoplay and slide advancement issue (#40409)#40421
Vijayshree25 wants to merge 8 commits intoampproject:mainfrom
Vijayshree25:fix-story-player-bug

Conversation

@Vijayshree25
Copy link

Fixes #40409

  • Added autoplay on story load
  • Prevented skipping of slides when user delays interaction
  • Ensured continuous story advancement without manual click

@CLAassistant
Copy link

CLAassistant commented Oct 30, 2025

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ erwinmombay
❌ VIJAYSHREE30530
You have signed the CLA already but the status is still pending? Let us recheck it.

@Vijayshree25
Copy link
Author

@newmuis Hi, requesting review for this PR. Needed for merge.

@Vijayshree25
Copy link
Author

Hi @newmuis @rileyjshaw @ampproject/wg-stories,
Requesting CI approval for this PR.
The workflow is blocked with "Awaiting approval" and cannot run.
Thanks!

@gbhrdt-cp
Copy link

Hi, any update here? We also need this merged for our customers

@mcsrnzlr
Copy link

Hi @newmuis @rileyjshaw and @ampproject/wg-stories,

Adding my voice here as an external website operator actively affected by issue #40409. The AMP Story Player autoplay and slide advancement regression is impacting live sites and this PR has been waiting since October 2025.

Looking at the current state: all 13 CI checks are failing, but based on the author's comments, this appears to be because the workflow was never approved for a first-time contributor not necessarily a code issue. @gbhrdt-cp raised the same concern in January with no response.

Could someone with write access please:

  1. Approve the CI run so the actual test results become visible
  2. Assign a reviewer once the checks have run

This would at minimum clarify whether the fix is ready to merge or needs further work — right now it's impossible to tell. Happy to help test against a live use case if that's useful. Thanks.

@rileyjshaw
Copy link

I have no idea why I’m being mentioned on this issue. I’m not a contributor to this project. Good luck with your issue.

@erwinmombay erwinmombay self-requested a review March 11, 2026 20:23
@erwinmombay
Copy link
Member

@mcsrnzlr i can take a look at this. rerunning the build

@erwinmombay
Copy link
Member

@Vijayshree25 do you mind rebasing the PR to get the code up to date if possible

@newmuis
Copy link
Contributor

newmuis commented Mar 12, 2026

Hi @Vijayshree25 and @erwinmombay! It's been quite a while since I've been a maintainer on this project, but just a few thoughts:

  • The way this is currently written, I believe this is a breaking change. There are sites that have not wanted the behavior that you're adding, and would want playback to be managed another way. If you were to add this functionality, you may want to consider adding a new opt-in (e.g. autoplay), so as not to break/change other pages.
  • As written, this assumes a single instance of amp-story-player on the page (i.e. querySelector), whereas you probably want to be open to the idea that there could be multiple (i.e. querySelectorAll).

@erwinmombay
Copy link
Member

appreciate the input @newmuis . hope you are well :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

AMP Story Player Issues

8 participants