Fix: Story Player autoplay and slide advancement issue (#40409)#40421
Fix: Story Player autoplay and slide advancement issue (#40409)#40421Vijayshree25 wants to merge 8 commits intoampproject:mainfrom
Conversation
|
|
|
@newmuis Hi, requesting review for this PR. Needed for merge. |
|
Hi @newmuis @rileyjshaw @ampproject/wg-stories, |
|
Hi, any update here? We also need this merged for our customers |
|
Hi @newmuis @rileyjshaw and @ampproject/wg-stories, Adding my voice here as an external website operator actively affected by issue #40409. The AMP Story Player autoplay and slide advancement regression is impacting live sites and this PR has been waiting since October 2025. Looking at the current state: all 13 CI checks are failing, but based on the author's comments, this appears to be because the workflow was never approved for a first-time contributor not necessarily a code issue. @gbhrdt-cp raised the same concern in January with no response. Could someone with write access please:
This would at minimum clarify whether the fix is ready to merge or needs further work — right now it's impossible to tell. Happy to help test against a live use case if that's useful. Thanks. |
|
I have no idea why I’m being mentioned on this issue. I’m not a contributor to this project. Good luck with your issue. |
|
@mcsrnzlr i can take a look at this. rerunning the build |
|
@Vijayshree25 do you mind rebasing the PR to get the code up to date if possible |
|
Hi @Vijayshree25 and @erwinmombay! It's been quite a while since I've been a maintainer on this project, but just a few thoughts:
|
|
appreciate the input @newmuis . hope you are well :) |
Fixes #40409