Switch to upstream ruamel.yaml package #399
Conversation
Avoid usage of deprecated top-level ruamel.yaml load/dump functions. Those have been removed in ruamel.yaml>=0.18 . Signed-off-by: Marcel Bargull <[email protected]>
ref: conda-incubator/setup-miniconda#261 Signed-off-by: Marcel Bargull <[email protected]>
.github/workflows/main.yml
Outdated
| - uses: conda-incubator/setup-miniconda@v2.1.1 | ||
| with: | ||
| auto-update-conda: false | ||
| miniconda-version: py37_4.10.3 |
There was a problem hiding this comment.
setup-miniconda>=2.2 does not handle the py37_ prefix, see conda-incubator/setup-miniconda#261 .
(Over all, it would make sense to update versions to test against. That would need knowledge of what versions of conda Anaconda intends to officially/unofficially support; i.e., not something I know and something better done in a separate PR.)
Signed-off-by: Marcel Bargull <[email protected]>
Signed-off-by: Marcel Bargull <[email protected]>
mbargull
force-pushed
the
ruamel.yaml
branch
from
48cb88d to
e733120
Compare
Signed-off-by: Marcel Bargull <[email protected]>
|
@AlbertDeFusco , the CI was probably affected by https://www.githubstatus.com/incidents/x39xrr5m11b3 . |
|
I've started the tests and I'll take a look |
Signed-off-by: Marcel Bargull <[email protected]>
|
I took another look at the CI log and it seems the path to the Conda installation simply changed from |
|
CI failures are unrelated to the changes here (mostly probably just test code needing adjustments to changes in |
|
Ping on this @AlbertDeFusco |
3 participants
Closes gh-364.
Supersedes gh-365.
Switch to upstream ruamel.yaml package.
Avoid usage of deprecated top-level ruamel.yaml load/dump functions. Those have been removed in ruamel.yaml>=0.18 .
The dependency change was similarly done for
conda>=22.11inruamel.yamlconda/conda#11868with the
ruamel_yamlfallback finally removed recently (forconda>23.10) in