Skip to content

Small fixes for v2 support#1011

Closed
Jipok wants to merge 4 commits intoanacrolix:masterfrom
Jipok:master
Closed

Small fixes for v2 support#1011
Jipok wants to merge 4 commits intoanacrolix:masterfrom
Jipok:master

Conversation

@Jipok
Copy link

@Jipok Jipok commented May 16, 2025

No description provided.

@anacrolix
Copy link
Owner

Thanks I'll verify soon

@Jipok
Copy link
Author

Jipok commented May 17, 2025

But I still couldn't get pure v2 to work. Here's my code for creating a torrent:
https://gist.github.com/Jipok/98cb92486378ad04b6c35e8bfe106314
It seems to create a valid torrent file. Another client finds it by infohash, gets the metadata and then gets stuck at 0.8%. There's no information in the logs.

@anacrolix
Copy link
Owner

Sorry for the delay, haven't had time to look yet. Have you tried with some regular, pure-v2 torrents from the wild?

@anacrolix
Copy link
Owner

Without looking too carefully I'll guess the v2 you're generating either isn't valid/correct, or any code that performs this function for you inside anacrolix/torrent doesn't do it right. I've tested only really only the reference torrents provided with the v2 spec. See #175 (comment) for the current state of the implementation.

Remove the addition of the torrent to the torrents map.

Pretty sure this was removed upstream, and I botched the merge.
@anacrolix
Copy link
Owner

I merged upstream. I have a feeling the torrentsByShortInfohash needs to be done consistently elsewhere, it's possible this has already been fixed due to refactoring upstream.

@anacrolix
Copy link
Owner

I'll close this, I think there's not enough value and it's not clear what is required now.

@anacrolix anacrolix closed this Feb 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants