Dev install packages #227
Draft
Dev install packages #227
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move package installation responsibility from the central kuiper-stages.sh loop into each stage's run.sh script. This improves the architecture: Before: - Central loop called install_packages() before each stage - install_packages() had a complex elif chain with tool-specific file names (packages-libiio, packages-desktop-with-recommends, etc.) and config checks - Config checks were duplicated: once in install_packages() and again in run.sh - Adding new tools required modifying the central kuiper-stages.sh After: - Each stage calls install_packages() within its own config check - install_packages() is a simple helper that looks for standard file names (packages, packages-with-recommends) in the stage's 00.install-packages/ - No duplication: config check only lives in run.sh - Adding new tools only requires creating a new stage directory Changes: - Simplify install_packages() from 40+ lines to ~10 lines - Move install_packages() call into each stage's run.sh - Rename package files to standard naming (packages, packages-with-recommends) - Embed 00.install-packages/ path in the helper function Each stage is now self-contained: config check, package installation, and build logic are all in one place. Signed-off-by: Alisa-Dariana Roman <[email protected]>
Replace direct ${BASH_SOURCE%%/run.sh} usage with a SCRIPT_DIR variable
defined once at the top of each script. This improves consistency and
readability across all stage scripts.
Changes:
- Add SCRIPT_DIR="${BASH_SOURCE%/run.sh}" to scripts that were missing it
- Replace all ${BASH_SOURCE%%/run.sh} usages with ${SCRIPT_DIR}
- Remove outdated comment explaining the BASH_SOURCE pattern
- Normalize inconsistent whitespace in install commands
Benefits:
- Single pattern across all stage scripts
- Path extraction done once per file, not repeated
- Eliminates % vs %% operator confusion
- Shorter, more readable install commands
Signed-off-by: Alisa-Dariana Roman <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Please replace this with a detailed description and motivation of the changes.
You can tick the checkboxes below with an 'x' between square brackets or just check them after publishing the PR.
If this PR contains a breaking change, list dependent PRs and try to push all related PRs at the same time.
PR Type
PR Checklist