package/sharc-firmware: new package by katiaTsaruk · Pull Request #129 · analogdevicesinc/buildroot

katiaTsaruk · 2026-08-25T14:43:20Z

Pre-built SHARC DSP rpmsg example firmware. Installs
adi_adsp_core1_fw.ldr and adi_adsp_core2_fw.ldr to /lib/firmware/
for use with the ADI remoteproc driver.

Firmware source: https://github.com/analogdevicesinc/rpmsg-examples

Depends on Makefile: add firmware install target rpmsg-examples#10
After release: update hash in sharc-firmware.hash

pamolloy · 2026-08-25T15:06:28Z

+	bool "sharc-firmware"
+	help
+	  Pre-built SHARC DSP rpmsg example firmware binaries.
+	  Installs adi_adsp_core1_fw.ldr and adi_adsp_core2_fw.ldr


Probably don't want to hardcode these file names in the package description. I currently have a PR open to add a new example

the problem is that the driver expects this files and loads them automatically in this case. Otherwise user needs to specify the files manually

oh wait you mean from config, will do

Although the vendor directory may not require changing the devicetree today, it combined with the fact that the dt is using generic/meaningless filenames means that we should update the devicetree for both of these points.

pamolloy · 2026-08-25T15:08:47Z

+	help
+	  Pre-built SHARC DSP rpmsg example firmware binaries.
+	  Installs adi_adsp_core1_fw.ldr and adi_adsp_core2_fw.ldr
+	  to /lib/firmware/ for use with the ADI remoteproc driver.


You don't need to specify that the remoteproc driver is from ADI since it should be transparent to the user.

The remoteproc driver loads the firmware onto the DSP core and executes it, but that isn't the point of installing the firmware. Just like installing a userspace application isn't to use systemd to start the program.

pamolloy · 2026-08-25T15:12:15Z

+config BR2_PACKAGE_SHARC_FIRMWARE
+	bool "sharc-firmware"
+	help
+	  Pre-built SHARC DSP rpmsg example firmware binaries.


Maybe mention Analog Devices, Inc. somewhere and what processors have these DSP cores (i.e. the A5 and A55 chips listed in https://analogdevicesinc.github.io/documentation/products/adsp/index.html). Note we need to add SC846!

pamolloy · 2026-08-25T15:16:57Z

+		$(TARGET_DIR)/lib/firmware/adi_adsp_core1_fw.ldr
+	$(INSTALL) -D -m 0644 \
+		$(@D)/echo_example/rpmsg_echo_example_Core2/Debug/rpmsg_echo_example_Core2.ldr \
+		$(TARGET_DIR)/lib/firmware/adi_adsp_core2_fw.ldr


How many packages install in /lib/firmware/ vs. /lib/firmware/<vendor>/?

this is what I told before, so the dts defines the name "adi_adsp_core1_fw.ldr", so if I add the vendor subfolder it won't match anymore

Normally in Buildroot there is a vendor directory, but for now we can just install in /lib/firmware/ so we don't need to change the devicetree, but eventually we should move it into a vendor directory, which should create a Github Issue for

pamolloy · 2026-08-25T15:21:13Z

Since this will go mainline I'd rephrase the commit message a little to be imperative (e.g. "Introduce a package to install ...") and remove the link since it is already contained in the package.

ozan956 · 2026-08-25T18:02:39Z

+	  Pre-built SHARC DSP rpmsg example firmware binaries from
+	  Analog Devices, Inc. for ADSP-SC57x, ADSP-SC58x, ADSP-SC594,
+	  ADSP-SC598, and ADSP-SC846 processors.


What about:

Pre-built SHARC firmware implementing RPMsg echo examples for validating communication between Linux and the SHARC cores on supported ADSP processors.

Plus are those processors supports the same ldr?

Good question, these packages were built for SC598. SC57x and SC58x use the older SHARC+, so need the separate firmware. I changed the text to your suggestion, as it is definitely much more safe.

ozan956 · 2026-08-25T18:04:02Z

@@ -0,0 +1,21 @@
+################################################################################
+#
+# sharc-firmware


Name sounds quite generic, are there any plans to extend that package with more stuff or is it just going to be RPMsg examples? If so we should rename.

It will just contain SHARC firmware. The naming matches other similar packages in Buildroot. For Buildroot maintainers or end users this name tells them that it is a package containing official firmware from ADI to run on the SHARC DSP cores.

pamolloy · 2026-08-26T09:19:04Z

+define SHARC_FIRMWARE_INSTALL_TARGET_CMDS
+	$(INSTALL) -D -m 0644 \
+		$(@D)/echo_example/rpmsg_echo_example_Core1/Debug/rpmsg_echo_example_Core1.ldr \
+		$(TARGET_DIR)/lib/firmware/adi_adsp_core1_fw.ldr


If this was a normal Linux userspace package you could add this as an install target in the project build file (i.e. meson). However here you could create a Makefile/CMakeLists/meson.build to just install the binaries in the rpmsg-examples repo.

This is also helpful because then we don't need to duplicate this in Yocto later.

I agree it is a good idea to do it and would also be consistent with other packages. Do you think, it should be done as the follow up in the other pr or still here, as I will need to change rpmsg-examples repo first.

analogdevicesinc/rpmsg-examples#10

Provide pre-built SHARC DSP rpmsg example firmware binaries for Analog Devices ADSP-SC5xx processors. Installs firmware to /lib/firmware/ for use with remoteproc. Signed-off-by: Kateryna Tsaruk <kateryna.tsaruk@analog.com>

katiaTsaruk self-assigned this Aug 25, 2026

katiaTsaruk requested review from ozan956 and pamolloy August 25, 2026 14:44

katiaTsaruk changed the base branch from master to adi-2026.02-y August 25, 2026 14:49

pamolloy added this to ADSP Aug 25, 2026

pamolloy reviewed Aug 25, 2026

View reviewed changes

katiaTsaruk mentioned this pull request Aug 25, 2026

Do not load DSP firmware from bootstrap image analogdevicesinc/br2-external#63

Open

1 task

pamolloy reviewed Aug 25, 2026

View reviewed changes

katiaTsaruk force-pushed the add-sharc-firmware branch from 1496cae to 8004494 Compare August 25, 2026 15:35

ozan956 reviewed Aug 26, 2026

View reviewed changes

pamolloy reviewed Aug 26, 2026

View reviewed changes

katiaTsaruk force-pushed the add-sharc-firmware branch from 8004494 to 4f73f08 Compare August 26, 2026 12:37

katiaTsaruk mentioned this pull request Aug 27, 2026

arm/arm64: dts: adi: remoteproc: use vendor firmware subdirectory analogdevicesinc/linux#3512

Open

katiaTsaruk force-pushed the add-sharc-firmware branch from 4f73f08 to fce256a Compare August 27, 2026 11:57

Uh oh!

Conversation

katiaTsaruk commented Aug 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

pamolloy commented Aug 25, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

katiaTsaruk Aug 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

pamolloy Aug 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

katiaTsaruk commented Aug 25, 2026 •

edited

Loading

katiaTsaruk Aug 26, 2026 •

edited

Loading

pamolloy Aug 26, 2026 •

edited

Loading