Skip to content

scripts: adi_env: Update Vivado to 2024.2 version #1571

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 16, 2025
Merged

scripts: adi_env: Update Vivado to 2024.2 version #1571

merged 3 commits into from
Apr 16, 2025

Conversation

ladace
Copy link
Contributor

@ladace ladace commented Feb 3, 2025

PR Description

Update Xilinx tools to 2024.2 version

PR Type

  • Bug fix (change that fixes an issue)
  • New feature (change that adds new functionality)
  • Breaking change (has dependencies in other repos or will cause CI to fail)

PR Checklist

  • I have followed the code style guidelines
  • I have performed a self-review of changes
  • I have compiled all hdl projects and libraries affected by this PR
  • I have tested in hardware affected projects, at least on relevant boards
  • I have commented my code, at least hard-to-understand parts
  • I have signed off all commits from this PR
  • I have updated the documentation (wiki pages, ReadMe files, Copyright etc)
  • I have not introduced new Warnings/Critical Warnings on compilation
  • I have added new hdl testbenches or updated existing ones

@ladace ladace force-pushed the dev_vivado_2024_2 branch from dee7ccf to b2f9217 Compare March 10, 2025 10:28
@ladace ladace requested a review from StancaPop as a code owner March 10, 2025 10:28
@ladace ladace force-pushed the dev_vivado_2024_2 branch from b2f9217 to 61363bb Compare March 10, 2025 15:35
@ladace
Copy link
Contributor Author

ladace commented Mar 10, 2025

V1:

  • Fix for CRITICAL WARNING 19-991
  • Fix for CRITICAL WARNING 19-1965

IuliaCMoldovan
IuliaCMoldovan reviewed Mar 11, 2025
View reviewed changes
library/axi_clkgen/axi_clkgen_ip.tcl Outdated
Comment on lines 21 to 23
set_property used_in_simulation false [get_files ./../scripts/adi_xilinx_device_info_enc.tcl]
set_property used_in_synthesis false [get_files ./bd/bd.tcl]
set_property used_in_synthesis false [get_files ./../scripts/adi_xilinx_device_info_enc.tcl]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wouldn't it be better if it was written with the $ad_hdl_dir, since it anyway is used at line 8?

Suggested change
set_property used_in_simulation false [get_files ./../scripts/adi_xilinx_device_info_enc.tcl]
set_property used_in_synthesis false [get_files ./bd/bd.tcl]
set_property used_in_synthesis false [get_files ./../scripts/adi_xilinx_device_info_enc.tcl]
set_property used_in_simulation false [get_files $ad_hdl_dir/library/scripts/adi_xilinx_device_info_enc.tcl]
set_property used_in_synthesis false [get_files ./bd/bd.tcl]
set_property used_in_synthesis false [get_files $ad_hdl_dir/library/scripts/adi_xilinx_device_info_enc.tcl]

@bia1708
Copy link
Collaborator

bia1708 commented Mar 12, 2025

RetriggerCI

@ladace ladace force-pushed the dev_vivado_2024_2 branch from 61363bb to a5fc727 Compare March 19, 2025 16:13
@ladace
Copy link
Contributor Author

ladace commented Mar 19, 2025

V2:

  • Fix for CRITICAL WARNING 19-1965 by modifying scripts/adi_ip_xilinx.tcl

@ladace ladace requested a review from LBFFilho as a code owner March 24, 2025 15:36
@ladace ladace force-pushed the dev_vivado_2024_2 branch from c066c77 to 04bc41e Compare March 24, 2025 15:37
IuliaCMoldovan
IuliaCMoldovan reviewed Apr 14, 2025
View reviewed changes
library/axi_clkgen/axi_clkgen_ip.tcl Outdated
set_property used_in_simulation false [get_files ./../scripts/adi_xilinx_device_info_enc.tcl]
set_property used_in_synthesis false [get_files ./bd/bd.tcl]
set_property used_in_synthesis false [get_files ./../scripts/adi_xilinx_device_info_enc.tcl]

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove one empty line

IuliaCMoldovan
IuliaCMoldovan requested changes Apr 14, 2025
View reviewed changes
Copy link
Contributor

@IuliaCMoldovan IuliaCMoldovan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update the copyright years for all the Tcl files that were touched

@sarpadi sarpadi requested a review from IuliaCMoldovan April 16, 2025 09:10
IuliaCMoldovan
IuliaCMoldovan previously approved these changes Apr 16, 2025
View reviewed changes
@sarpadi sarpadi force-pushed the dev_vivado_2024_2 branch 2 times, most recently from ce8cf41 to 8ac7e91 Compare April 16, 2025 10:41
ladace added 2 commits April 16, 2025 21:51
@ladace @sarpadi
scripts: adi_env: Update Vivado to 2024.2 version
28234ee 
Signed-off-by: Liviu 'Ceshu' Adace <[email protected]>
Signed-off-by: sarpadi <[email protected]>
@ladace @sarpadi
library: Fix for CRITICAL WARNING 19-991
42187ed 
Fixes for:
CRITICAL WARNING: [IP_Flow 19-991] Unrecognized or unsupported file 'bd/bd.tcl' found in file group 'Synthesis'.
CRITICAL WARNING: [IP_Flow 19-991] Unrecognized or unsupported file 'bd/bd.tcl' found in file group 'Simulation'.

Signed-off-by: Liviu 'Ceshu' Adace <[email protected]>
Signed-off-by: sarpadi <[email protected]>
@ladace @sarpadi
library: Fix for CRITICAL WARNING 19-1965
b878259 
Fixes for:
CRITICAL WARNING: [IP_Flow 19-1965] Bus Interface 'xyz': A port map to the required logical port "abc" of the bus abstraction "analog.com:interface:'interface':1.0" is missing.

Signed-off-by: Liviu 'Ceshu' Adace <[email protected]>
@sarpadi sarpadi force-pushed the dev_vivado_2024_2 branch from fb8604b to b878259 Compare April 16, 2025 20:51
@sarpadi sarpadi merged commit a22fce4 into main Apr 16, 2025
3 of 4 checks passed
@sarpadi sarpadi deleted the dev_vivado_2024_2 branch April 16, 2025 20:54
@gastmaier
Copy link
Contributor

@ladace Committing the XML files generated by the interfaces_ip.tcl files during the build flow is strange.
Are we sure that we are not resolving the warning by providing interface files that may be outdated?
For example, if I modify an interface in ainterfaces_ip.tcl, now I also have to commit the xml file, which sounds like a regression to me;
or if I forget to commit the xml, it seems that vivado will take the old XML instead of the new one generated by interfaces_ip.tcl during build.

Did we try to ensure interfaces_ip.tcl is run before the libraries that depend on it (M_DEPS := interfaces_ip.tcl) are generated?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sarpadi sarpadi sarpadi approved these changes

@IuliaCMoldovan IuliaCMoldovan IuliaCMoldovan approved these changes

@acostina acostina Awaiting requested review from acostina acostina is a code owner

@AndreiGrozav AndreiGrozav Awaiting requested review from AndreiGrozav AndreiGrozav is a code owner

@PopPaul2021 PopPaul2021 Awaiting requested review from PopPaul2021 PopPaul2021 is a code owner

@gastmaier gastmaier Awaiting requested review from gastmaier gastmaier is a code owner

@AndrDragomir AndrDragomir Awaiting requested review from AndrDragomir AndrDragomir is a code owner

@FilipG24 FilipG24 Awaiting requested review from FilipG24 FilipG24 is a code owner

@bluncan bluncan Awaiting requested review from bluncan bluncan is a code owner

@podgori podgori Awaiting requested review from podgori podgori is a code owner

@StancaPop StancaPop Awaiting requested review from StancaPop StancaPop is a code owner

@LBFFilho LBFFilho Awaiting requested review from LBFFilho

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ladace @bia1708 @gastmaier @sarpadi @IuliaCMoldovan