library/spi_engine: fix PCORE_VERSION #1637
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Commit 24f2454 ("SPI Engine: simplify interconnect (analogdevicesinc#1502)") bumped the patch version in the documentation but missed changing it in PCORE_VERSION which is the value used by the version register. Signed-off-by: David Lechner <[email protected]>
dlech
requested review from
sarpadi,
podgori,
StancaPop and
ladace
as code owners
Commit 24f2454 ("SPI Engine: simplify interconnect (analogdevicesinc#1502)") made it so that the SYNC command is no longer required. This is actually a "feature" we want to test for. So that commit should have bumped the minor version instead of the patch version. Bump the version now so that we can test for this feature in the software driver. Signed-off-by: David Lechner <[email protected]>
dlech
requested review from
IuliaCMoldovan,
gastmaier and
LBFFilho
as code owners
|
It turns out that being able to omit the SYNC instruction is a feature that is useful to obtain 4MSPS on 16-bit ADC w/ 80MHz SCLK. So I added another patch to bump the version even more so that we can test for this feature in software. Assuming that I interpreted the commit message correctly and SYNC really is no longer required. 😄 |
6 tasks
LBFFilho
previously approved these changes
Apr 25, 2025
LBFFilho
approved these changes
Apr 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit 24f2454 ("SPI Engine: simplify interconnect (#1502)") bumped the patch version in the documentation but missed changing it in PCORE_VERSION which is the value used by the version register.
PR Description
Please replace this comment with summary, motivation and context of the changes.
List any dependencies required for this change.
You can check the checkboxes below by inserting a 'x' between square brackets
(without any other characters or spaces) or just check them after publishing the PR.
If there is a breaking change, specify dependent PRs in description and
try to push all related PRs at the same time.
PR Type
PR Checklist