Skip to content

projects: ad5706r: coraz7s: add project#1997

Open
actorreno wants to merge 2 commits into
mainfrom
dev_ad5706r_spi_engine
Open

projects: ad5706r: coraz7s: add project#1997
actorreno wants to merge 2 commits into
mainfrom
dev_ad5706r_spi_engine

Conversation

@actorreno

@actorreno actorreno commented Jan 27, 2026

Copy link
Copy Markdown
Contributor

PR Description

The AD5706R devices are 4-channel, 16-/12-/10-bit resolution, low noise,
programmable current output, digital-to-analog converter (DAC) capable of
multiple operating modes and output current ranges with high power efficiency.
The family provides multiple programmable output current ranges up to 300mA.

The project uses SPI engine to reach 50MHz transactions on CoraZ7S FPGA.

PR Type

  • Bug fix (change that fixes an issue)
  • New feature (change that adds new functionality)
  • Breaking change (has dependencies in other repos or will cause CI to fail)
  • Documentation

PR Checklist

  • I have followed the code style guidelines
  • I have performed a self-review of changes
  • I have compiled all hdl projects and libraries affected by this PR
  • I have tested in hardware affected projects, at least on relevant boards
  • I have commented my code, at least hard-to-understand parts
  • I have signed off all commits from this PR
  • I have updated the documentation (wiki pages, ReadMe files, Copyright etc)
  • I have not introduced new Warnings/Critical Warnings on compilation
  • I have added new hdl testbenches or updated existing ones

@actorreno actorreno force-pushed the dev_ad5706r_spi_engine branch from e3f9abb to bbe5db3 Compare January 27, 2026 05:26
@actorreno actorreno marked this pull request as ready for review January 27, 2026 08:45
gastmaier
gastmaier reviewed Jan 27, 2026
View reviewed changes
Comment thread projects/ad5706r/README.md Outdated
@@ -0,0 +1,32 @@
\# AD5706R HDL Project

@gastmaier gastmaier Jan 27, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the file is oddly formatted

@actorreno actorreno Jan 28, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated this.

@actorreno actorreno force-pushed the dev_ad5706r_spi_engine branch from bbe5db3 to 439549e Compare January 28, 2026 03:05
@actorreno actorreno requested a review from gastmaier January 28, 2026 03:11
@actorreno actorreno force-pushed the dev_ad5706r_spi_engine branch from 439549e to ca65c57 Compare February 12, 2026 07:54
gastmaier
gastmaier previously requested changes Feb 12, 2026
View reviewed changes

@gastmaier gastmaier left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

doc review changes

Comment thread docs/projects/ad5706r/index.rst Outdated
Comment thread docs/projects/ad5706r/index.rst Outdated
Comment thread docs/projects/ad5706r/index.rst Outdated
Comment thread docs/projects/ad5706r/index.rst Outdated
Comment thread docs/projects/ad5706r/index.rst Outdated
Comment thread docs/projects/ad5706r/index.rst Outdated
Comment thread docs/projects/ad5706r/index.rst Outdated
@actorreno actorreno force-pushed the dev_ad5706r_spi_engine branch 2 times, most recently from f13d5ed to 9074378 Compare February 13, 2026 05:30
@actorreno

actorreno commented Feb 13, 2026

Copy link
Copy Markdown
Contributor Author

v2:

  • Applied minor corrections in index.rst from reviews
  • RTL was requested to remove PWM and DMA now that I used light version of SPI Engine
  •  - updated the block diagram to remove pwm/dma

  •  - removed some entries in the docu regarding the pwm/dma

@actorreno actorreno force-pushed the dev_ad5706r_spi_engine branch from 9074378 to 62e53d9 Compare February 16, 2026 00:06
@actorreno actorreno requested a review from gastmaier February 16, 2026 00:24
sarpadi
sarpadi requested changes Feb 17, 2026
View reviewed changes
Comment thread projects/ad5706r/common/ad5706r_bd.tcl
StancaPop
StancaPop previously requested changes Feb 17, 2026
View reviewed changes
Comment thread projects/ad5706r/README.md
@actorreno actorreno force-pushed the dev_ad5706r_spi_engine branch from 62e53d9 to 8a94515 Compare February 18, 2026 01:42
@actorreno

actorreno commented Feb 18, 2026

Copy link
Copy Markdown
Contributor Author

v3:

  • Adjusted TCL for clk_gen
  • Edited README as suggested

sarpadi
sarpadi previously requested changes Mar 3, 2026
View reviewed changes
Comment thread projects/ad5706r/common/ad5706r_bd.tcl
Comment thread projects/ad5706r/common/ad5706r_bd.tcl
@actorreno actorreno force-pushed the dev_ad5706r_spi_engine branch 2 times, most recently from a5ad418 to 7051431 Compare April 10, 2026 03:04
@actorreno

actorreno commented Apr 10, 2026

Copy link
Copy Markdown
Contributor Author

v4:

  • simplified architecture, does not use spi_engine anymore and related IPs.
  • removed mention of those IPs in documentation

This change is to reflect the linux driver and the discussed requirements that makes this
simplification acceptable

@actorreno actorreno requested a review from sarpadi April 10, 2026 03:13
actorreno added 2 commits May 12, 2026 16:03
@actorreno
docs: projects: adding docs for ad5706r
ac257e0 
The AD5706R devices are 4-channel, 16-/12-/10-bit resolution, low noise,
programmable current output, digital-to-analog converter (DAC) capable of
multiple operating modes and output current ranges with high power efficiency.
The family provides multiple programmable output current ranges up to 300mA.

Signed-off-by: Alexis Czezar Torreno <alexisczezar.torreno@analog.com>
@actorreno
projects: ad5706r: coraz7s: add project
9c1f796 
The AD5706R devices are 4-channel, 16-/12-/10-bit resolution, low noise,
programmable current output, digital-to-analog converter (DAC) capable of
multiple operating modes and output current ranges with high power efficiency.
The family provides multiple programmable output current ranges up to 300mA.

Signed-off-by: Alexis Czezar Torreno <alexisczezar.torreno@analog.com>
@actorreno actorreno force-pushed the dev_ad5706r_spi_engine branch from 7051431 to 9c1f796 Compare May 12, 2026 08:04
@actorreno

actorreno commented May 12, 2026

Copy link
Copy Markdown
Contributor Author

rebased to latest main, to avoid merge conflict

@actorreno actorreno dismissed stale reviews from sarpadi, StancaPop, and gastmaier May 20, 2026 07:37

not using spi engine anymore

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@IuliaCMoldovan IuliaCMoldovan Awaiting requested review from IuliaCMoldovan IuliaCMoldovan is a code owner

@LBFFilho LBFFilho Awaiting requested review from LBFFilho LBFFilho is a code owner

@acostina acostina Awaiting requested review from acostina acostina is a code owner

@AndreiGrozav AndreiGrozav Awaiting requested review from AndreiGrozav AndreiGrozav is a code owner

@PopPaul2021 PopPaul2021 Awaiting requested review from PopPaul2021 PopPaul2021 is a code owner

@gastmaier gastmaier Awaiting requested review from gastmaier gastmaier is a code owner

@StancaPop StancaPop Awaiting requested review from StancaPop StancaPop is a code owner

@sarpadi sarpadi Awaiting requested review from sarpadi sarpadi is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@actorreno @gastmaier @sarpadi @StancaPop