Skip to content

Refactor to use gdk_threads_add_idle instead of gdk_threads_enter/leave #505

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 28, 2025

Conversation

trupples
Copy link
Contributor

PR Description

  • Please replace this comment with a summary of your changes, and add any context
    necessary to understand them. List any dependencies required for this change.
  • To check the checkboxes below, insert a 'x' between square brackets (without
    any space), or simply check them after publishing the PR.
  • If you changes include a breaking change, please specify dependent PRs in the
    description and try to push all related PRs simultaneously.

PR Type

  • Bug fix (a change that fixes an issue)
  • New feature (a change that adds new functionality)
  • Breaking change (a change that affects other repos or cause CIs to fail)

PR Checklist

  • I have followed the coding standards and guidelines
  • I have conducted a self-review of my own code changes
  • I have commented new code, particulary complex or unclear areas
  • I have checked in CI output that no new warnings/errors got introduced
  • I have updated documentation accordingly (GitHub Pages, READMEs, etc)

Copy link
Contributor

@nunojsa nunojsa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM... As @dNechita pointed out, we need to make sure it works on all supported OSes and to remove all the calls to gdk_threads_enter()/leave() also in the plugins (in a patch per plugin)

@trupples trupples force-pushed the main branch 2 times, most recently from db47643 to c52b7a8 Compare November 14, 2024 11:18
@trupples trupples marked this pull request as ready for review March 25, 2025 12:28
@trupples
Copy link
Contributor Author

trupples commented Mar 25, 2025

Tested on Ubuntu and Windows manually:

  • context scan & select dialog behaves as expected
  • fmcomms2_adv plugin changes seem to be on an unreachable code path anyway (starting with gtk signal do_fmcomms5_cal, which doesn't exist)
  • fmcomms2_adv plugin otherwise looks and behaves as expected UI-wise, tested w/ Pluto

@dNechita
Copy link
Contributor

  • do_fmcomms5_cal

do_fmcomms5_cal is the name of button and is defined in the UI files (https://github.com/analogdevicesinc/iio-oscilloscope/blob/main/glade/fmcomms2_adv.glade#L6177).

@trupples
Copy link
Contributor Author

Tested calibration UI with iio-emu generic pyadi-iio/test/emu/devices/fmcomms5.xml as a stand-in for an actual fmcomms5, and it seems to work ok. Couldn't get any samples to plot but I guess that's the setup's fault.

@cristina-suteu cristina-suteu merged commit d4f019f into analogdevicesinc:main Mar 28, 2025
6 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants