Skip to content

Libiio1 plot single channels mask #516

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 6, 2025

Conversation

dNechita
Copy link
Contributor

@dNechita dNechita commented Feb 6, 2025

PR Description

We need to keep just one channels mask across iio-osc. This is needed in order to be able to accurately count the number of enabled channels.

PR Type

  • Bug fix (a change that fixes an issue)
  • New feature (a change that adds new functionality)
  • Breaking change (a change that affects other repos or cause CIs to fail)

PR Checklist

  • I have followed the coding standards and guidelines
  • I have conducted a self-review of my own code changes
  • I have commented new code, particulary complex or unclear areas
  • I have checked in CI output that no new warnings/errors got introduced
  • I have updated documentation accordingly (GitHub Pages, READMEs, etc)

in osc.c, each struct iio_device and iio_channel get assigned some dynamically allocated memory which never gets freed.

Signed-off-by: Dan Nechita <[email protected]>
@dNechita dNechita force-pushed the libiio1-plot-single-channels-mask branch from bfce87b to 2b5fd7e Compare February 6, 2025 10:34
Copy link
Contributor

@nunojsa nunojsa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Only nit comment is about the subject in the second commit. Not really a treewide change IMO but rather something in osc: ... (and yes, I realize you are also changing an header file :))

@dNechita dNechita force-pushed the libiio1-plot-single-channels-mask branch from 2b5fd7e to 6b410f0 Compare February 6, 2025 12:37
@dNechita
Copy link
Contributor Author

dNechita commented Feb 6, 2025

LGTM. Only nit comment is about the subject in the second commit. Not really a treewide change IMO but rather something in osc: ... (and yes, I realize you are also changing an header file :))

Solved! Thanks for reviewing this.

@dNechita dNechita merged commit 3954063 into libiio1-plot Feb 6, 2025
2 of 4 checks passed
@dNechita dNechita deleted the libiio1-plot-single-channels-mask branch February 6, 2025 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants