Skip to content

Fix read_sampling_frequency #531

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 31, 2025
Merged

Fix read_sampling_frequency #531

merged 1 commit into from
Mar 31, 2025

Conversation

cristina-suteu
Copy link
Contributor

@cristina-suteu cristina-suteu commented Mar 28, 2025

PR Description

when the sampling freq is a channel specific attribute, the effective sampling freq is calculated depending on the sampling frequencies of each enabled channel
this also ensures effective capture timeout calculation
fixes issue #489

PR Type

  • Bug fix (a change that fixes an issue)
  • New feature (a change that adds new functionality)
  • Breaking change (a change that affects other repos or cause CIs to fail)

PR Checklist

  • I have followed the coding standards and guidelines
  • I have conducted a self-review of my own code changes
  • I have commented new code, particulary complex or unclear areas
  • I have checked in CI output that no new warnings/errors got introduced
  • I have updated documentation accordingly (GitHub Pages, READMEs, etc)

when the sampling freq is a channel specific attribute, the effective
sampling freq is calculated depending on the sampling frequencies of each
enabled channel
this ensures effective timeout calculation

Signed-off-by: Cristina Suteu <[email protected]>
@cristina-suteu cristina-suteu merged commit 9b75f53 into main Mar 31, 2025
7 of 10 checks passed
@cristina-suteu cristina-suteu deleted the fix-timeout branch March 31, 2025 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants