Fix/libiiov1 segfault #535
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iio_create_context() now returns an error pointer instead of NULL when a context is not properly created. This was later leading to a segmentation fault. Signed-off-by: Nuno Sá <[email protected]>
nunojsa
requested review from
cristina-suteu,
dNechita and
mhennerich
as code owners
dNechita
reviewed
Apr 7, 2025
libini2.c
Outdated
Comment on lines
261
to
268
|
|
||
| /*for (i = 0; i < iio_device_get_channels_count(dev); i++) | ||
| iio_channel_attr_read_all(iio_device_get_channel(dev, i), | ||
| save_to_ini_chn_cb, ¶ms); | ||
| iio_device_attr_read_all(dev, save_to_ini_dev_cb, ¶ms); | ||
|
|
||
| params.is_debug = true; | ||
| iio_device_debug_attr_read_all(dev, save_to_ini_dev_cb, ¶ms);*/ |
There was a problem hiding this comment.
@cristina-suteu you disabled this code in this commit (1a67750). Is it not required at all?
There was a problem hiding this comment.
Oh, yes... it might be that I just blindly removed stuff without giving it a thought if it needs rewriting...
There was a problem hiding this comment.
Hmm, and I just see that likely all of the unused stuff is because of that commented code.... If it needs a rewrite, I can drop this commit
There was a problem hiding this comment.
I think it's best to drop the commit now. Keep it local or on a separate branch in case it turns out it is needed.
Get rid of an unused variable... Signed-off-by: Nuno Sá <[email protected]>
nunojsa
force-pushed
the
fix/libiiov1-segfault
branch
from
e1a8300 to
bc83e35
Compare
|
v2:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
Main patch is to fix a segfault when we fail to properly IIO context. Rest is just removal of dead unused code...
PR Type
PR Checklist