[RFC PATCH v5] iio: repeat channel support and dummy client example #43
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Lucas Magasweran <[email protected]>
Linux struct iio_chan_spec supports a 'repeat' scan_type attribute that represents the number of times the element repeats. A value of 0 and 1 signifies no repeat. In order maintain backwards and forwards compatibility, the repeat field was added to the end of the struct. This means applications compiled against an older version will work fine with the newer dynamically linked library. Applications compiled against a newer version will work fine with the older dynamically linked library so long as they don't access this new feature. Applications using this new feature should ensure the libiio version is compatible by using iio_library_get_version() to avoid undefined behavior. Signed-off-by: Lucas Magasweran <[email protected]>
…-hrtimer Signed-off-by: Lucas Magasweran <[email protected]>
This matches the optional X%u repeat count in sysfs _type scan element format attribute. Signed-off-by: Lucas Magasweran <[email protected]>
Signed-off-by: Lucas Magasweran <[email protected]>
|
Merged. Thanks! |
|
I'm sure you did set the commit date on purpose ;) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
iio_chan_typeIIO_ROTuses the repeat channeliio_chan_spec.scan_type.repeatto store repeated elements in a channel without modifiers.This patch series adds support to
libiioand creates a new example tool that exercises theiio_dummydriver. For testing this series theiio_dummycan be patched to include theIIO_ROTchannel. See lucasrangit/linux-iio#1 .Signed-off-by: Lucas Magasweran [email protected]
Changes since v1:
format->repeat > 1for consistent output and avoid duplicatedprintfand squashed commits since this is a new sample tool
Changes since v2:
struct iio_data_formatmemberrepeatto the end of the struct to maintain forward ABI compatibility.iio_library_get_version().Changes since v4: