hwmon: (pmbus/adp1050): Support adp1051 and adp1055 by actorreno · Pull Request #2629 · analogdevicesinc/linux

actorreno · 2024-10-24T08:28:48Z

PR Description

This adds ADP1051 and ADP1055 driver support on existing ADP1050 Driver.
Datasheets ADP1051, ADP1055.
Tested on RPI4 using the following eval boards: ADP1051-EVB, ADP1055-EVB.

PR Type

Bug fix (a change that fixes an issue)
New feature (a change that adds new functionality)
Breaking change (a change that affects other repos or cause CIs to fail)

PR Checklist

I have conducted a self-review of my own code changes
I have tested the changes on the relevant hardware
I have updated the documentation outside this repo accordingly (if there is the case)

nunojsa

Another hint is to run:

git log --oneline drivers/hwmon/pmbus to look for the style used in that dir for commit titles. The most common seems to be (adapted for your case):

hwmon: (pmbus/adp1050): Support adp1051 and adp1055

nunojsa · 2024-10-25T07:45:14Z


 description: |
-   The ADP1050 is used to monitor system voltages, currents and temperatures.
+   The ADP1050, ADP1051, and ADP1055 are used to monitor system voltages,


This does not scale. Instead say "The ADP1050 and similar devices..."

nunojsa · 2024-10-25T07:45:55Z

   and has four individual monitors for input/output voltage, input current
   and temperature.
   Datasheet:
     https://www.analog.com/en/products/adp1050.html


Just add here the links to new datasheets

nunojsa · 2024-10-25T07:47:03Z


        hwmon@70 {
-            compatible = "adi,adp1050";
+            compatible = "adi,adp1050", "adi,adp1051";


It does not work like this... If you can fallback to some compatible, that needs to be stated in the bindings which is not.

nunojsa · 2024-10-25T07:47:20Z

+            compatible = "adi,adp1050", "adi,adp1051";
            reg = <0x70>;
            vcc-supply = <&vcc>;
+            status = "okay";


remove the status

nunojsa · 2024-10-25T07:47:45Z

+            compatible = "adi,adp1055";
+            reg = <0x4b>;
+            vcc-supply = <&vcc>;
+            status = "okay";


If it#s only a matter of the address being different, I would not bother in adding another example

nunojsa · 2024-10-25T07:54:22Z

+		   | PMBUS_HAVE_VIN | PMBUS_HAVE_STATUS_INPUT
+		   | PMBUS_HAVE_IIN | PMBUS_HAVE_TEMP
+		   | PMBUS_HAVE_STATUS_TEMP,
+};


Also unrelated change. I would drop it (or add it in a different patch)

nunojsa · 2024-10-25T07:56:20Z

+	ADP1050,
+	ADP1051,
+	ADP1055,
+};


Drop the id

nunojsa · 2024-10-25T07:56:40Z

-	{ .compatible = "adi,adp1050"},
+	{ .compatible = "adi,adp1050", .data = (void *)ADP1050},
+	{ .compatible = "adi,adp1051", .data = (void *)ADP1051},
+	{ .compatible = "adi,adp1055", .data = (void *)ADP1055},


pass in directly the pmbus_driver_info structs...

nunojsa · 2024-10-25T07:57:29Z

-	{"adp1050", 0},
+	{"adp1050", ADP1050},
+	{"adp1051", ADP1051},
+	{"adp1055", ADP1055},


here you need a cast but there are examples:

https://elixir.bootlin.com/linux/v6.11.5/source/drivers/iio/addac/ad74413r.c#L1530

nunojsa · 2024-10-25T07:58:12Z

-	return pmbus_do_probe(client, &adp1050_info);
+	enum ADP1050_type type;
+
+	type = (enum ADP1050_type)(uintptr_t)device_get_match_data(&client->dev);


Now you can properly do error checking:

info = device_get_match_data(); if (!info) return -ENODEV;

actorreno · 2024-10-28T02:22:23Z

v2

.yaml:

updated description to scale as suggested
removed further descriptions and simply attached datasheet links
reverted back most of the device tree sample
(just a lack of understanding on the yaml file, i thought it was a full device tree)
(no fallback feature intended, but will note just in case)

.rst

dropped the small unrelated change

.c

dropped the unrelated change, astyle adjusts this each run
dopped the ID and directly passed the pmbus structs
used the error checking as suggested

nunojsa

Fell free to send this upstream...

nunojsa · 2024-11-04T15:56:12Z

+      - enum:
+          - adi,adp1050
+          - adi,adp1051
+          - adi,adp1055


On top of what I've said already, you don't need "items:" in here (as you have things now at least).

nunojsa · 2024-11-04T15:56:57Z

-	return pmbus_do_probe(client, &adp1050_info);
+	struct pmbus_driver_info *info;
+
+	info = (struct pmbus_driver_info *)device_get_match_data(&client->dev);


no need for the cast..

I added the cast just to remove a warning but yes this can be removed to simplify the code further.

edit: removal of the cast started failing some of the checks. is this ok?

nunojsa · 2024-11-04T15:57:23Z

 			 const struct i2c_device_id *id)
 {
-	return pmbus_do_probe(client, &adp1050_info);
+	struct pmbus_driver_info *info;


It can be const pmbus_driver_info *info

const pmbus_driver_info *info; returns an error similar to the one below. Will keep the original struct pmbus_driver_info *info;

Obviously a typo from me... const struct pmbus_driver_info *info and then no need for the cast

updated the commit but still fails some checks.

a warning remains it seems

Yes, my bad... pmbus_do_probe() discards the const qualifier. Sorry for the noise.

reverted back to original

struct pmbus_driver_info *info;

nunojsa · 2025-01-22T11:34:03Z

Please send this upstream so we can merge this here

actorreno · 2025-01-24T02:44:49Z

This was already sent upstream. However, the maintainers caught this and another driver LTP8800 to be somewhat similar and suggested we combine them and send together in one patch. There was feedback on LTP8800 and am still waiting for updates on it. Will apply the recent feedback here too to the upstream when ready.

Also it seems the main branch file was updated and I merged/resolved conflicts it above. I hope this is ok.
The main file change seems to be related to the probe() version not being 6.1 anymore

/* 6.1 probe() function still uses the second struct i2c_device_id argument */
static int adp1050_probe(struct i2c_client *client,
const struct i2c_device_id *id)

nunojsa · 2025-07-02T13:31:19Z

Hi, I'm just checking in on the status of this pull request. Is there anything I can do to help move it forward?

actorreno · 2025-07-04T06:55:02Z

I got in touch with the one handling the other part and it seems this was the latest update:
https://lore.kernel.org/all/Z5O-avYZkWsD-Vka@smile.fi.intel.com/
I already got in touch with the other engineer to start moving this forward, the feedbacks doesn't seem too hard so I am hoping something substantial happen next week. Thanks!

nunojsa · 2025-07-04T07:43:31Z

I got in touch with the one handling the other part and it seems this was the latest update:
https://lore.kernel.org/all/Z5O-avYZkWsD-Vka@smile.fi.intel.com/
I already got in touch with the other engineer to start moving this forward, the feedbacks doesn't seem too hard so I am hoping something substantial happen next week. Thanks!

Please, it looks pretty much ready to be accepted so...

actorreno · 2025-07-17T03:00:18Z

v3 - Upstream applied:

cherry picked the applied patches

This PR is now the merged drivers of adp1051, adp1055, and ltp8800

Linked here is the old pull request for ltp8800
#2611

nunojsa

It seems it still needs some care this PR. I definitely don't expect that merge commit in here. Please rebase and apply the patches.

Add support for adp1051, adp1055, and ltp8800. ADP1051: 6 PWM for I/O Voltage, I/O Current, Temperature ADP1055: 6 PWM for I/O Voltage, I/O Current, Power, Temperature LTP8800-1A/-2/-4A: 150A/135A/200A DC/DC µModule Regulator Co-developed-by: Alexis Czezar Torreno <alexisczezar.torreno@analog.com> Signed-off-by: Alexis Czezar Torreno <alexisczezar.torreno@analog.com> Signed-off-by: Cedric Encarnacion <cedricjustine.encarnacion@analog.com> Acked-by: Conor Dooley <conor.dooley@microchip.com> Link: https://lore.kernel.org/r/20250709-adp1051-v5-1-539254692252@analog.com Signed-off-by: Guenter Roeck <linux@roeck-us.net>

Introduce hardware monitoring support for the following devices: ADP1051: 6 PWM for I/O Voltage, I/O Current, Temperature ADP1055: 6 PWM for I/O Voltage, I/O Current, Power, Temperature LTP8800-1A/-2/-4A: 150A/135A/200A DC/DC µModule Regulator The ADP1051 and ADP1055 are similar digital controllers for high efficiency DC-DC power conversion while the LTP8800 is a family of step-down μModule regulators that provides microprocessor core voltage from 54V power distribution architecture. All of the above components features telemetry monitoring of input/output voltage, input current, output power, and temperature over PMBus. Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> Co-developed-by: Alexis Czezar Torreno <alexisczezar.torreno@analog.com> Signed-off-by: Alexis Czezar Torreno <alexisczezar.torreno@analog.com> Signed-off-by: Cedric Encarnacion <cedricjustine.encarnacion@analog.com> Link: https://lore.kernel.org/r/20250709-adp1051-v5-2-539254692252@analog.com [groeck: Dropped unnecessaary spaces after type casts] Signed-off-by: Guenter Roeck <linux@roeck-us.net>

Add regulator support for the single-channel LTP8800-1A/-2/-4A 150A/135A/200A DC/DC µModule Regulator. Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> Signed-off-by: Cedric Encarnacion <cedricjustine.encarnacion@analog.com> Link: https://lore.kernel.org/r/20250709-adp1051-v5-3-539254692252@analog.com Signed-off-by: Guenter Roeck <linux@roeck-us.net>

actorreno requested review from CiprianRegus, amiclaus, btogorean, buha, chegbeli, danmois, dbogdan, machschmitt, mhennerich, nunojsa and rbolboac as code owners October 24, 2024 08:28

actorreno force-pushed the dev/adp1050_support branch 8 times, most recently from ca32f70 to ffc9249 Compare October 25, 2024 02:57

nunojsa reviewed Oct 25, 2024

View reviewed changes

actorreno changed the title ~~Added support for ADP1051 and ADP1055 on existing ADP1050 driver~~ hwmon: (pmbus/adp1050): Support adp1051 and adp1055 Oct 25, 2024

actorreno force-pushed the dev/adp1050_support branch 2 times, most recently from 39943c4 to 9a7485b Compare October 28, 2024 01:59

actorreno requested a review from nunojsa October 31, 2024 01:06

nunojsa reviewed Nov 4, 2024

View reviewed changes

actorreno force-pushed the dev/adp1050_support branch 2 times, most recently from 82c4d40 to 72a535b Compare November 5, 2024 08:29

actorreno force-pushed the dev/adp1050_support branch from 72a535b to 7b8e680 Compare January 24, 2025 01:49

actorreno requested a review from nunojsa July 18, 2025 01:16

nunojsa requested changes Oct 10, 2025

View reviewed changes

nunojsa mentioned this pull request Oct 10, 2025

Add driver for LTP8800-1A, LTP8800-4A and LTP8800-2 #2611

Closed

6 tasks

cencarna added 3 commits October 10, 2025 17:18

actorreno force-pushed the dev/adp1050_support branch from db5163b to b167147 Compare October 10, 2025 09:19

nunojsa approved these changes Oct 10, 2025

View reviewed changes

nunojsa merged commit fbc9486 into main Oct 10, 2025
28 of 30 checks passed

nunojsa deleted the dev/adp1050_support branch October 10, 2025 13:38

github-actions Bot pushed a commit that referenced this pull request Oct 10, 2025

deploy: fbc9486 #2629 (closed)

a721883

Conversation

actorreno commented Oct 24, 2024

PR Description

PR Type

PR Checklist

Uh oh!

nunojsa left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

actorreno commented Oct 28, 2024

Uh oh!

nunojsa left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

actorreno Nov 5, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

nunojsa commented Jan 22, 2025

Uh oh!

actorreno commented Jan 24, 2025

Uh oh!

nunojsa commented Jul 2, 2025

Uh oh!

actorreno commented Jul 4, 2025

Uh oh!

nunojsa commented Jul 4, 2025

Uh oh!

actorreno commented Jul 17, 2025

Uh oh!

nunojsa left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

actorreno Nov 5, 2024 •

edited

Loading