iio: adc: adrv9002: fix ignored error code#3032
Merged
Conversation
With commit 5547b3a ("iio: adc: adrv9002: support RX port switching") we now return -EINVAL in adrv9002_get_init_carrier(). However, the function footprint was not updated and we kept returning u64 which is obviously wrong. Update the function to return int and get the carrier as an argument pointer. Fixes: 5547b3a ("iio: adc: adrv9002: support RX port switching") Signed-off-by: Nuno Sá <nuno.sa@analog.com>
nunojsa
requested review from
CiprianRegus,
amiclaus,
btogorean,
buha,
chegbeli,
danmois,
dbogdan,
machschmitt,
mhennerich and
rbolboac
as code owners
Collaborator
|
Linux Test Harness results now available here. |
mhennerich
approved these changes
Dec 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Description
With commit 5547b3a ("iio: adc: adrv9002: support RX port switching") we now return -EINVAL in adrv9002_get_init_carrier(). However, the function footprint was not updated and we kept returning u64 which is obviously wrong. Update the function to return int and get the carrier as an argument pointer.
Fixes: 5547b3a ("iio: adc: adrv9002: support RX port switching")
PR Type
PR Checklist