azure-pipelines-rpi: add cloudsmith upload support for rpi artifacts#3053
azure-pipelines-rpi: add cloudsmith upload support for rpi artifacts#3053
Conversation
AAndrisa
requested review from
CiprianRegus,
amiclaus,
btogorean,
buha,
chegbeli,
danmois,
dbogdan,
machschmitt,
mhennerich,
nunojsa and
rbolboac
as code owners
amiclaus
left a comment
amiclaus
left a comment
There was a problem hiding this comment.
looks good overall, minor questions.
|
|
||
| #upload artifacts to Cloudsmith | ||
| artifacts_cloudsmith() { | ||
| artifacts_structure |
There was a problem hiding this comment.
maybe consider adding set -e?
AAndrisa
force-pushed
the
cloudsmith_rpi
branch
from
4a4eee3 to
dc1e1e5
Compare
There was a problem hiding this comment.
Some comments from me...
I would like to see this separated in two patches. First add the code needed for the job and then enable it in the .yml file.
But the more fundamental question is about @gastmaier CI work. Won't we want this being done as part of that pipeline? I would like, at some point, top get rid of the duplicated CI we have today.
| tar -C ${PWD}/32bit -czvf rpi_latest_boot_32bit.tar.gz . | ||
| tar -C ${PWD}/64bit -czvf rpi_latest_boot_64bit.tar.gz . | ||
| rm -r ./32bit | ||
| rm -r ./64bit |
There was a problem hiding this comment.
Regarding the duplicated work, we want to keep the azure pipeline until we ensure that the github action ones export also the current structure that we use in the boot partition for Kuiper. This applies also for the main linux build, not just rpi one.
There was a problem hiding this comment.
Alright, can you still update the PT based on comments?
…rpi artifacts Add function for cloudsmith support in the prepare_artifacts_rpi.sh script to upload the rpi artifacts. Signed-off-by: Andreea Andrisan <Andreea.Andrisan@analog.com>
Implement upload to Cloudsmith step in the rpi ci infrastructure. Signed-off-by: Andreea Andrisan <Andreea.Andrisan@analog.com>
AAndrisa
force-pushed
the
cloudsmith_rpi
branch
from
dc1e1e5 to
bf3df41
Compare
3 participants
PR Description
Add function for cloudsmith support in the prepare_artifacts_rpi.sh script to upload the rpi artifacts.
PR Type
PR Checklist