Skip to content

checks: run qconfig sync for selected defconfigs#70

Open
ozan956 wants to merge 1 commit intocifrom
qconfig-check
Open

checks: run qconfig sync for selected defconfigs#70
ozan956 wants to merge 1 commit intocifrom
qconfig-check

Conversation

@ozan956
Copy link
Copy Markdown

@ozan956 ozan956 commented Mar 13, 2026

Replace the defconfig assert step with a check_qconfig() helper
that runs qconfig.py on the selected defconfigs and reports any issues.

@ozan956 ozan956 force-pushed the qconfig-check branch 9 times, most recently from 0f5d8e2 to 923d14f Compare March 19, 2026 08:28
@ozan956 ozan956 changed the title checks.yml: add qconfig sync check for defconfigs checks: pass defconfigs for assert checks Mar 19, 2026
@ozan956
Copy link
Copy Markdown
Author

ozan956 commented Mar 19, 2026

@ozan956 ozan956 requested review from gastmaier and pamolloy March 19, 2026 08:39
@ozan956 ozan956 added this to ADSP Mar 19, 2026
@ozan956 ozan956 self-assigned this Mar 19, 2026
@ozan956 ozan956 marked this pull request as ready for review March 19, 2026 08:39
@ozan956 ozan956 force-pushed the qconfig-check branch 2 times, most recently from f79492c to b71d069 Compare March 19, 2026 10:20
@pamolloy pamolloy requested a review from woodrowbarlow March 19, 2026 10:28
@ozan956 ozan956 force-pushed the qconfig-check branch 4 times, most recently from 30c47fb to b623c44 Compare March 19, 2026 11:30
@ozan956 ozan956 changed the title checks: pass defconfigs for assert checks checks: run qconfig sync for selected defconfigs Mar 19, 2026
@ozan956
Copy link
Copy Markdown
Author

ozan956 commented Mar 19, 2026

We decided to replace defconfig checks that is based on make defconfig with the qconfig.py, since it already includes that functionality and brings more useful checks on defconfigs.

See the test runs here:
https://github.com/analogdevicesinc/u-boot/actions/runs/23292194091/job/67731708726
https://github.com/analogdevicesinc/u-boot/actions/runs/23293850361/job/67735983551#step:10:35

@ozan956 ozan956 force-pushed the qconfig-check branch 3 times, most recently from f86ffff to 56107bc Compare March 19, 2026 11:50
Replace the defconfig assert step with a check_qconfig() helper
that runs qconfig.py on the selected defconfigs and reports any issues.

Signed-off-by: Ozan Durgut <ozan.durgut@analog.com>
@pamolloy
Copy link
Copy Markdown
Collaborator

@gastmaier can you take a look at this PR? You may also be interested in https://docs.u-boot.org/en/latest/develop/qconfig.html#qconfig-querying-config-options

Copy link
Copy Markdown
Collaborator

@gastmaier gastmaier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For context, the o.g. implementation is copy from
https://github.com/analogdevicesinc/linux/blob/ci/ci/build.sh#L370-L412

Comment thread ci/build.sh

git restore .
git clean -fd -e ci/

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So qconfig.py has a few options.
You are calling with -d a file containing a list of defconfigs to move and -s force sync by savedefconfig.
There is also a --test option for unit tests but

 """Run doctests and unit tests (so far there are no unit tests)"""

:)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: No status

Development

Successfully merging this pull request may close these issues.

3 participants