feat(create-analog): Node.js compat with Angular v22 and @angular/animations deprecation#2375
feat(create-analog): Node.js compat with Angular v22 and @angular/animations deprecation#2375alejandrocuba wants to merge 7 commits into
Conversation
✅ Deploy Preview for analog-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for analog-blog ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for analog-app ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
📝 WalkthroughWalkthroughThis PR updates root package.json engines to require Node ^22.22.3 || ^24.15.0 || ^26.0.0 and pnpm ^11.0.0, bumps packageManager to pnpm@11.5.3, removes the top-level pnpm block from package.json, adds allowBuilds and overrides to pnpm-workspace.yaml, and removes Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes 🚥 Pre-merge checks | ✅ 4✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
alejandrocuba
changed the title
alejandrocuba
changed the title
alejandrocuba
changed the title
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@package.json`:
- Around line 25-28: The engines.node field was tightened to "node": "^22.22.3
|| ^24.15.0 || ^26.0.0" which aligns with Angular 22 but may break installs for
users on earlier patch versions; update the PR description/commit message to
document this as a breaking change by adding a "BREAKING CHANGES:" footer that
shows before/after install examples (e.g., prior engines value vs new engines
value and sample npm/pnpm install failure vs success) and ensure the
package.json change is left as-is (do not relax engines.node back to ^22.0.0 ||
^24.0.0).
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: d5efc7cb-73e3-4f5e-866c-fe570e0ef35f
⛔ Files ignored due to path filters (1)
pnpm-lock.yamlis excluded by!**/pnpm-lock.yamland included by none
📒 Files selected for processing (5)
package.jsonpackages/create-analog/template-blog/package.jsonpackages/create-analog/template-latest/package.jsonpackages/create-analog/template-minimal/package.jsonpnpm-workspace.yaml
💤 Files with no reviewable changes (3)
- packages/create-analog/template-latest/package.json
- packages/create-analog/template-blog/package.json
- packages/create-analog/template-minimal/package.json
alejandrocuba
left a comment
alejandrocuba
left a comment
There was a problem hiding this comment.
Added the breaking change note in the PR description
|
Thanks @alejandrocuba. The starter templates are here for blog, latest, and minimal. Also its not a breaking change for new apps. https://github.com/analogjs/analog/tree/beta/packages/create-analog |
|
@brandonroberts I've updated the PR description to mark it as non-breaking. Also, my local clone was pointing to a very outdated main branch, which caused an issue with the removal of @angular/animations in the starter templates, but everything has now been fixed and cleaned up. Please review the changes. Thanks! |
2 participants
PR Checklist
@angular/animationspackage is also specified as a dependency in the repo and starter templates.Affected scope
Recommended merge strategy for maintainer [optional]
Commit preservation note [optional]
What is the new behavior?
package.jsonto thepnpm-workspace.yamlfile underallowBuildsandoverrides.@angular/animationsTest plan
nx format:checkpnpm build:pnpm testDoes this PR introduce a breaking change?
This PR drops support for Node v20. Anyone working in the workspace or running scaffolding templates must upgrade their Node.js runtime environment to at least v22.22.3
Other information
[optional] What gif best describes this PR or how it makes you feel?