Skip to content

fix(vite-plugin-angular): remove stale esbuild export#2379

Closed
82040613-spec wants to merge 1 commit into
analogjs:betafrom
82040613-spec:patch-1
Closed

fix(vite-plugin-angular): remove stale esbuild export#2379
82040613-spec wants to merge 1 commit into
analogjs:betafrom
82040613-spec:patch-1

Conversation

@82040613-spec

Copy link
Copy Markdown

Summary

Removes the stale ./esbuild subpath export from @analogjs/vite-plugin-angular.

The 2.x package manifest currently points ./esbuild to ./esbuild.js, but published 2.x packages no longer include that file. Importing @analogjs/vite-plugin-angular/esbuild therefore resolves to a missing file and fails with ERR_MODULE_NOT_FOUND.

Notes

  • 1.22.5 included esbuild.js / esbuild.d.ts.
  • 2.0.0 through 2.6.1 no longer include those files but still keep the export.
  • 3.0.0-alpha.59 no longer exports ./esbuild.

Fixes #2377.

The 2.x package exports ./esbuild to ./esbuild.js, but the published package no longer includes that file. Remove the stale subpath export so consumers do not resolve to a missing file.
@netlify

netlify Bot commented Jun 12, 2026

Copy link
Copy Markdown

Deploy Preview for analog-blog ready!

Name Link
🔨 Latest commit afa8519
🔍 Latest deploy log https://app.netlify.com/projects/analog-blog/deploys/6a2b9a7f06f1bf0008a0bc52
😎 Deploy Preview https://deploy-preview-2379--analog-blog.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify

netlify Bot commented Jun 12, 2026

Copy link
Copy Markdown

Deploy Preview for analog-docs ready!

Name Link
🔨 Latest commit afa8519
🔍 Latest deploy log https://app.netlify.com/projects/analog-docs/deploys/6a2b9a7f5a94710008b13c24
😎 Deploy Preview https://deploy-preview-2379--analog-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify

netlify Bot commented Jun 12, 2026

Copy link
Copy Markdown

Deploy Preview for analog-app ready!

Name Link
🔨 Latest commit afa8519
🔍 Latest deploy log https://app.netlify.com/projects/analog-app/deploys/6a2b9a7ffeaf030008c5f880
😎 Deploy Preview https://deploy-preview-2379--analog-app.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@coderabbitai

coderabbitai Bot commented Jun 12, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: f6def662-63fd-4ce9-861f-b6fcd6967f15

📥 Commits

Reviewing files that changed from the base of the PR and between cff12cd and afa8519.

📒 Files selected for processing (1)
  • packages/vite-plugin-angular/package.json

📝 Walkthrough

Walkthrough

This PR removes the ./esbuild subpath export from packages/vite-plugin-angular/package.json. The export pointed to ./esbuild.js, which does not exist in the published package and has been missing since version 2.0.0, causing runtime import failures. The ./setup-vitest export remains unchanged.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

🚥 Pre-merge checks | ✅ 4
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The PR title follows Conventional Commit style with the correct scope (vite-plugin-angular) and concisely summarizes the main change (removing stale esbuild export).
Description check ✅ Passed The PR description clearly explains the problem, provides version history context, and directly relates to the changeset (removing the stale ./esbuild export).
Linked Issues check ✅ Passed The code changes directly address the primary objective in #2377: removing the stale ./esbuild export that pointed to a missing file in published 2.x packages.
Out of Scope Changes check ✅ Passed All changes are scoped to the single objective of removing the stale export from package.json; no unrelated modifications are present.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

@analogjs/vite-plugin-angular exports ./esbuild to missing esbuild.js in 2.x

2 participants