Tighten workflow-level permissions#74
Merged
Merged
Conversation
Set top-level `permissions: {}` in all three workflow files and push
`contents: read` down to the job level where it is actually needed.
Signed-off-by: Alex Goodman <wagoodman@users.noreply.github.com>
wagoodman
added
the
changelog-ignore
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Set top-level
permissions: {}in all three workflow files so no permissions are granted at the workflow level by default. Per-job permissions that are actually needed are pushed down to the job level.Changes:
permissions: contents: read→permissions: {}(release job already hadcontents: writeat job level)permissions: contents: read→permissions: {}(zizmor job already had job-level permissions)permissions: contents: read→permissions: {}; addcontents: readto each job that needs itNotes: