feat: handle ROOTIO_UNAFFECTED markers in OS transformer#736
feat: handle ROOTIO_UNAFFECTED markers in OS transformer#736chait-slim wants to merge 1 commit intoanchore:mainfrom
Conversation
|
In its current form, this is not the change suggested at anchore/vunnel#863 (comment) . https://github.com/anchore/grype-db/pull/686/files#diff-af698832ba49e27cd15a534e0c885e607ec0eb94a07cd2165f03f09a2265bcbeR61-R70 has an example. To re-iterate:
|
- Detect Root.io vulnerability records by namespace prefix (rootio:)
- Create UnaffectedPackageHandle entries for packages with .root.io suffix
- Support Root.io namespace format: rootio:distro:{os}:{version}
- Add OS-aware constraint handling for different package types
- Process Root.io data as fix records without sentinel values
Enables Grype to filter false positives for Root.io patched packages
by querying unaffected package handles from the database.
29c6218 to
a2ee299
Compare
@willmurphyscode I've refactored the three PRs according to the requirements and comments. Given what I understand about the project and your comments I think the PRs will meet the requirements much better now |
Hi @willmurphyscode did you get a chance to look at the updated PRs? |
|
|
Hi @willmurphyscode, apologies for the close/reopen notification, that was an accidental misclick on my end! I wanted to bump this because getting this landed is currently a high priority for my team. With the holidays approaching in a couple of weeks, I’m eager to get your eyes on this so I can address any remaining requests or fixes before the break. I’d really appreciate a review when you have a moment so we don't carry any blockers into the new year. Thanks! |
| "AdvisorySummary": [], | ||
| "NoAdvisory": true | ||
| }, | ||
| "Version": "", |
There was a problem hiding this comment.
I'm confused. This looks like a vulnerability with no fix information in a test case, but at anchore/vunnel#863 (comment) I thought you said that the rootio provider never discloses unfixed vulnerabilities.
|
Opened a new PR with updated spec: #790 |
This enables grype-db to properly process Root.io security patches
and prevent false positive vulnerability matches.
Signed-off-by: Chai Tadmor chai.tadmor@root.io