Skip to content

fix: improve platform CPE determination logic #3470

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
spiffcs merged 1 commit into from
Jun 1, 2026
+176 −4
Merged

fix: improve platform CPE determination logic #3470

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 18 additions & 4 deletions grype/db/v6/build/transformers/nvd/node.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ import (
"github.com/anchore/grype/grype/db/internal/provider/unmarshal/nvd"
"github.com/anchore/grype/internal/log"
"github.com/anchore/syft/syft/cpe"
"github.com/scylladb/go-set/strset"
)

type affectedPackageCandidate struct {
Expand Down Expand Up @@ -250,21 +251,34 @@ func extractVulnerableCPEs(node nvd.Node, cfg Config) ([]affectedPackageCandidat

// extractPlatformCPEs extracts all platform CPEs from a node (explicitly non-vulnerable CPEs). Why not just
// use the part indication (i.e. 'h' & 'o' are platform and 'a' is the vulnerable candidate)? Because you can
// find cases where an application is the platform (e.g. kubernetes or openshift).
// find cases where an application is the platform (e.g. kubernetes or openshift). Any platform CPE candidate
// must be non-vulnerable across all cpeMatch elements of the node, otherwise unaffected package entries will be
// mistakenly raised up as platforms
func extractPlatformCPEs(node nvd.Node) ([]cpe.Attributes, error) {
var platformCPEs []cpe.Attributes
platformCPEMap := make(map[string][]cpe.Attributes)
packageCandidates := strset.New()

for _, match := range node.CpeMatch {
cpeAttr, err := cpe.NewAttributes(match.Criteria)
if err != nil {
return nil, fmt.Errorf("unable to parse CPE '%s': %w", match.Criteria, err)
}

if !match.Vulnerable {
platformCPEs = append(platformCPEs, cpeAttr)
key := cpeKey(cpeAttr)
if match.Vulnerable {
packageCandidates.Add(key)
delete(platformCPEMap, key)
} else if !packageCandidates.Has(key) {
platformCPEMap[key] = append(platformCPEMap[key], cpeAttr)
}
}

var platformCPEs []cpe.Attributes

for _, platforms := range platformCPEMap {
platformCPEs = append(platformCPEs, platforms...)
}

return platformCPEs, nil
}

Expand Down
68 changes: 68 additions & 0 deletions ...build/transformers/nvd/testdata/product-affected-and-unaffected-range-with-platforms.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,68 @@
{
"cve": {
"id": "CVE-2025-30331111111",
"sourceIdentifier": "security@mozilla.org",
"published": "2025-04-01T13:15:41.697",
"lastModified": "2026-04-13T15:16:57.157",
"vulnStatus": "Modified",
"cveTags": [],
"descriptions": [
{
"lang": "en",
"value": ""
}
],
"configurations": [
{
"nodes": [
{
"cpeMatch": [
{
"criteria": "cpe:2.3:a:mozilla:firefox:*:*:*:*:*:*:*:*",
"matchCriteriaId": "21CE0201-DC5C-5924-95C1-B46F85CE3F2D",
"versionEndExcluding": "137",
"vulnerable": true,
"fix": {
"version": "137",
"date": "2025-09-04",
"kind": "first-observed"
}
},
{
"criteria": "cpe:2.3:a:mozilla:firefox_esr:*:*:*:*:*:*:*:*",
"matchCriteriaId": "0C620750-B827-56C5-A96A-9AEC0EE2F3AD",
"versionEndExcluding": "137",
"vulnerable": true,
"fix": {
"version": "137",
"date": "2025-09-04",
"kind": "first-observed"
}
},
{
"criteria": "cpe:2.3:a:mozilla:firefox:108:*:*:*:*:*:*:*",
"matchCriteriaId": "0C620750-B827-56C5-A96A-9AEC0EE2F3AD",
"vulnerable": false
}
],
"negate": false,
"operator": "OR"
},
{
"cpeMatch": [
{
"criteria": "cpe:2.3:o:microsoft:windows:-:*:*:*:*:*:*:*",
"matchCriteriaId": "A2572D17-1DE6-457B-99CC-64AFD54487EA",
"vulnerable": false
}
],
"negate": false,
"operator": "OR"
}
],
"operator": "AND"
}
],
"references": []
}
}
90 changes: 90 additions & 0 deletions grype/db/v6/build/transformers/nvd/transform_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2161,6 +2161,96 @@ func TestTransform(t *testing.T) {
},
},
},
{
name: "Determine platform CPEs from node with both affected and unaffected product ranges",
fixture: "testdata/product-affected-and-unaffected-range-with-platforms.json",
provider: "nvd",
config: defaultConfig(),
want: []transformers.RelatedEntries{
{
VulnerabilityHandle: &db.VulnerabilityHandle{
Name: "CVE-2025-30331111111",
ProviderID: "nvd",
Provider: expectedProvider("nvd"),
ModifiedDate: timeRef(time.Date(2026, 4, 13, 15, 16, 57, 157000000, time.UTC)),
PublishedDate: timeRef(time.Date(2025, 4, 1, 13, 15, 41, 697000000, time.UTC)),
Status: db.VulnerabilityActive,
BlobValue: &db.VulnerabilityBlob{
ID: "CVE-2025-30331111111",
Assigners: []string{"security@mozilla.org"},
Description: "",
References: []db.Reference{
{
URL: "https://nvd.nist.gov/vuln/detail/CVE-2025-30331111111",
},
},
},
},
Related: relatedEntries(
db.AffectedCPEHandle{
BlobValue: &db.PackageBlob{
CVEs: []string{"CVE-2025-30331111111"},
Qualifiers: &db.PackageQualifiers{
PlatformCPEs: []string{"cpe:2.3:o:microsoft:windows:-:*:*:*:*:*:*:*"},
},
Ranges: []db.Range{
{
Version: db.Version{
Constraint: "< 137",
},
Fix: &db.Fix{
Version: "137",
State: db.FixedStatus,
Detail: &v6.FixDetail{
Available: &v6.FixAvailability{
Date: timeRef(time.Date(2025, 9, 4, 0, 0, 0, 0, time.UTC)),
Kind: "first-observed",
},
},
},
},
},
},
CPE: &db.Cpe{
Part: "a",
Vendor: "mozilla",
Product: "firefox",
},
},
db.AffectedCPEHandle{
BlobValue: &db.PackageBlob{
CVEs: []string{"CVE-2025-30331111111"},
Qualifiers: &db.PackageQualifiers{
PlatformCPEs: []string{"cpe:2.3:o:microsoft:windows:-:*:*:*:*:*:*:*"},
},
Ranges: []db.Range{
{
Version: db.Version{
Constraint: "< 137",
},
Fix: &db.Fix{
Version: "137",
State: db.FixedStatus,
Detail: &v6.FixDetail{
Available: &v6.FixAvailability{
Date: timeRef(time.Date(2025, 9, 4, 0, 0, 0, 0, time.UTC)),
Kind: "first-observed",
},
},
},
},
},
},
CPE: &db.Cpe{
Part: "a",
Vendor: "mozilla",
Product: "firefox_esr",
},
},
),
},
},
},
}

for _, test := range tests {
Expand Down