fix: add facebook as additional CPE vendor for react npm package#4682
Open
dreamcreated wants to merge 1 commit intoanchore:mainfrom
Open
fix: add facebook as additional CPE vendor for react npm package#4682dreamcreated wants to merge 1 commit intoanchore:mainfrom
dreamcreated wants to merge 1 commit intoanchore:mainfrom
Conversation
The NVD uses 'facebook' as the vendor for React in CPE identifiers: cpe:2.3:a:facebook:react:<version>:*:*:*:*:*:*:* Syft was generating 'react' as the vendor, which caused failures in vulnerability matching tools like DependencyTrack because the generated CPE did not match the NVD canonical form. Fixes anchore#4653 Changes: - Add react to defaultCandidateAdditions with AdditionalVendors: ["facebook"] - Add regression tests in TestGeneratePackageCPEs and TestCandidateVendor
Contributor
|
Hey @dreamcreated it looks like you just need to sign-off your commit(s); thanks for fixing this! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #4653
The NVD uses
facebookas the vendor for React in CPE identifiers:Syft was generating
reactas the vendor:This caused failures in vulnerability matching tools like DependencyTrack because the generated CPE did not match the NVD canonical form, preventing CVE matching for React packages.
Changes
reacttodefaultCandidateAdditionsincandidate_by_package_type.gowithAdditionalVendors: ["facebook"]TestGeneratePackageCPEsandTestCandidateVendorthat verify thefacebookvendor is includedTesting
All existing tests pass.
References