Skip to content

chore(YouTube - Translations): Update Korean #1039

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Apr 24, 2025
Merged

Conversation

BlackGold8282
Copy link
Contributor

chore(YouTube - Translations): Update Korean

@anddea
Copy link
Owner

anddea commented Apr 22, 2025

In order to avoid a merge conflict, sending new strings here

<?xml version='1.0' encoding='utf-8'?>
<resources>
    <string name="revanced_copy_error">Failed to copy text</string>
    <string name="revanced_gemini_error_dialog_show">Error showing dialog</string>
    <string name="revanced_gemini_error_translation_failed">Gemini translation failed</string>
    <string name="revanced_gemini_error_translation_parse_failed">Gemini translation parsing failed</string>
    <string name="revanced_gemini_loading_default">Loading...</string>
    <string name="revanced_gemini_status_translating">Translating with Gemini...\n\n⚠️ This step may fail if Gemini ignores the instructions or hits the limit.</string>
    <string name="revanced_yandex_error_api_final_subs">Yandex API error fetching final subtitles (Code: %1$d)</string>
    <string name="revanced_yandex_error_api_poll">Yandex API error during poll (Code: %1$d)</string>
    <string name="revanced_yandex_error_download_subs_failed">Failed to download subtitle file (Code: %1$d)</string>
    <string name="revanced_yandex_error_internal_missing_translation_id">Internal error: Missing translation ID</string>
    <string name="revanced_yandex_error_internal_request_build">Internal error building request</string>
    <string name="revanced_yandex_error_network_final_subs">Network error fetching final subtitles</string>
    <string name="revanced_yandex_error_network_generic">Network error</string>
    <string name="revanced_yandex_error_network_poll">Network error during poll</string>
    <string name="revanced_yandex_error_no_language_selected">No language selected</string>
    <string name="revanced_yandex_error_parsing_final_subs">Failed to parse final Yandex subtitles list</string>
    <string name="revanced_yandex_error_parsing_poll">Failed to parse Yandex poll response</string>
    <string name="revanced_yandex_error_reading_response">Error reading API response</string>
    <string name="revanced_yandex_error_session_expired">Yandex session expired</string>
    <string name="revanced_yandex_error_session_refresh_failed">Failed to refresh Yandex session</string>
    <string name="revanced_yandex_error_subs_parsing_failed">Failed to parse subtitle JSON content</string>
    <string name="revanced_yandex_error_subs_processing_failed">Error processing subtitle content</string>
    <string name="revanced_yandex_error_timeout_final_fetch">Timed out before fetching final subtitles after %1$d seconds</string>
    <string name="revanced_yandex_error_timeout_poll">Timed out waiting for translation after %1$d seconds (Poll #%2$d)</string>
    <string name="revanced_yandex_error_timeout_processing">Timed out during translation processing after %1$d seconds</string>
    <string name="revanced_yandex_status_youtube_specific">Handling YouTube audio request...</string>
    
    <!-- UPDATED STRINGS -->
    <string name="revanced_yandex_transcribe_subtitles_summary">Use Yandex transcription instead of Gemini. Yandex is faster and more reliable. No API key is required.</string>
    <string name="revanced_yandex_transcribe_subtitles_language_summary">"Yandex can transcribe videos from any language, but the output is available only in English (en), Russian (ru) and Kazakh (kk). If you enter any other language code or use 'app' (which stands for the app's default language), Gemini will be asked to translate (API key is required)."</string>
</resources>

@BlackGold8282
Copy link
Contributor Author

Timed out ... after %1$d seconds
// It says it will time out in a few seconds, right?

(Code: %1$d)
// code is an HTTP status code like 400 or 403, right?

@anddea
Copy link
Owner

anddea commented Apr 23, 2025

The first one is the number of seconds, timeout sends failure message that it took too long, for example this line shows max time to wait: 15 minutes (but it will show it in seconds for consistency, because the timer in the dialog is also in seconds).

private static final long WORKFLOW_TIMEOUT_MS = 15 * 60 * 1000; // 15 minutes total timeout

The second one, yes, the HTTP response code.

@BlackGold8282
Copy link
Contributor Author

done...

but only “revanced_yandex_transcribe_subtitles_language_summary” was removed, right?

@anddea
Copy link
Owner

anddea commented Apr 24, 2025

Don't worry about removed strings, before next release, the automation script will remove everything not used or not relevant anymore, will sort all strings, etc.

@anddea anddea merged commit 0a46d98 into anddea:dev Apr 24, 2025
1 check passed
@BlackGold8282
Copy link
Contributor Author

BlackGold8282 commented Apr 24, 2025

But when translating, don't I need to locate it against the original String.xml (english)?
I added the translation at the bottom at the beginning of the translation, but you seem to be aligning it.

I heard that there is overheat and battery drain for RVX in Galaxy ONE UI 7.0 and I don't know why (I'm not a Galaxy user).

I heard from inotia that new YT Setting UI (Cairo?) does not currently hide the settings menu.

@anddea
Copy link
Owner

anddea commented Apr 24, 2025

But when translating, don't I need to locate it against the original String.xml (english)?

No, all missing strings are already in missing_strings.xml, and you can just add them at the end of the strings.xml file, I'll merge and then later my automation script will fix everything, if any errors detected. If i add something to updated_strings.xml, then it means this string is already in strings.xml (for the same language), so it cannot be added to missing strings, then you need to find this string and replace with new translation, otherwise it will show an error that duplicates found, although my automation can fix it too, except it won't know which one is newer and might delete the wrong one.

I heard that there is overheat and battery drain for RVX in Galaxy ONE UI 7.0 and I don't know why (I'm not a Galaxy user).

Unfortunately I cannot test it either, but any Galaxy user can test and let us know which patch(es) causing it. There can be any reason for it, smali instructions or logic behind functions invoked by those smali instructions, they all can require more resources which will potentially drain battery faster. Or maybe even OS itself, especially if it is reproducible in original app. Also, OS might optimize for few days after updating, which will consume more resources as well.

I heard from inotia that new YT Setting UI (Cairo?) does not currently hide the settings menu.

What does it mean? We currently do not use Cairo settings because something does not work, inotia is more aware of this element, probably that's why he blocks Cairo settings from loading, because settings menu items (like General, Account, etc.) cannot be hidden, did I understand you correctly?

@anddea
Copy link
Owner

anddea commented Apr 24, 2025

Yes, that's expected, they probably can be hidden with resource patch (which previously also had some issues).

@BlackGold8282
Copy link
Contributor Author

file_00000000cb1861f7a6522d23fd68a3e5

If Download button is changed to a Queue Manager button, is it possible to change the button text to a “Queue” or “Queue Manager” button?

(Image was created with ChatGPT;;;)

@anddea
Copy link
Owner

anddea commented Apr 30, 2025

Not sure about that yet. The queue manager is hooked to a download button with Smali instructions, but text for the button is coming as a litho component, which is hard to change. If I'm not wrong. We have the same problem with DeArrow. DeArrow has anti-clickbait titles, but so far no one could make it possible to work in ReVanced/RVX. On the web it is so much easier to do, that's why web extensions are more functional.

@0xrxL
Copy link

0xrxL commented May 3, 2025

@anddea Try it! ReVanced/revanced-patches#4904

@anddea
Copy link
Owner

anddea commented May 4, 2025

I wonder where inotia is. Do you possess any information about that?

Previously, I’ve been waiting for him to merge changes from ReVanced to avoid duplicating the process from both RV and RVX. Now I’m unsure—should I keep waiting? The same situation occurred with the Swipe controls patch, the new UI thing (there are new changes now that I'm thinking about merging too): I waited for a while, then merged the changes myself. Later, inotia merged his version, but I ended up skipping his updates (they differ a little bit), resulting in a small discrepancy in that area.

@anddea
Copy link
Owner

anddea commented May 4, 2025

Wasn't there a secret group for rvx major developers (contributors) on Telegram?

I'm not aware of this. I believe ReVanced Team has a Discord server with a development channel where they discuss topics related to development (at least, there was such a thing before, I don't have a Discord account now to verify it).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants