#167891584 Notifications for new travel request(in-app notification) - #58
Open
Pomile wants to merge 1 commit into
Open
#167891584 Notifications for new travel request(in-app notification)#58Pomile wants to merge 1 commit into
Pomile wants to merge 1 commit into
Conversation
Pomile
force-pushed
the
ft-inAppNotification-forNewTravelRequest-167891584
branch
from
September 10, 2019 13:30
91484ff to
f26d807
Compare
Pomile
force-pushed
the
ft-inAppNotification-forNewTravelRequest-167891584
branch
from
September 11, 2019 15:04
f26d807 to
f41df56
Compare
Pomile
force-pushed
the
ft-inAppNotification-forNewTravelRequest-167891584
branch
10 times, most recently
from
September 14, 2019 19:03
f2526b2 to
92c5dd4
Compare
tvpeter
reviewed
Sep 15, 2019
| </i> | ||
| Start Location</div> | ||
| <div class="dataclip-body-line"> | ||
| >>>>>>> feat(inApp-notification): Implement in-app notification feature for new |
Collaborator
There was a problem hiding this comment.
lines 52, 57 & 66 have conflict you are yet to resolve.
Pomile
force-pushed
the
ft-inAppNotification-forNewTravelRequest-167891584
branch
from
September 17, 2019 03:37
92c5dd4 to
fa94d62
Compare
travel request - [x] Install socket.io and sockect.io-client - [x] Create in-app client - [x] Create sockect io server - [x] Create endpoint that test inapp feature from through a browser - [x] Modify new trip request method [Finishes #167891584]
Pomile
force-pushed
the
ft-inAppNotification-forNewTravelRequest-167891584
branch
from
September 17, 2019 10:25
fa94d62 to
34f9819
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Send in-app message to the admin user.
Description of Task to be completed?
How should this be manually tested?
Unit test
git pullgit checkout ft-inAppNotification-configOpt-endpoint-167891584npm installdatabase_nameDevelopment test with Postman
npm run devstart/api/v1/trips/test/in_app/api/v1/tripsWhat are the relevant pivotal tracker stories?
#167891584
Any background context you want to add?
Nil
Screenshots