Skip to content

#167891606 Rate An Accomodation - #66

Open
femitj wants to merge 1 commit into
developfrom
ft-rate-centre-167891606
Open

#167891606 Rate An Accomodation#66
femitj wants to merge 1 commit into
developfrom
ft-rate-centre-167891606

Conversation

@femitj

@femitj femitj commented Sep 15, 2019

Copy link
Copy Markdown
Collaborator

What does this PR do?

Users can rate an accomodation centre

Description of Task to be completed?

  • Defines the rating model for the database
  • Creates the migration file for the database
  • Creates seeder file for the database
  • Creates controllers and routes
  • Creates validations

How should this manually be Tested?

  • git clone this repo
  • git checkout ft-rate-centre-167891606 branch
  • run npm i
  • run npm db:reset

What are the relevant Pivotal Tracker stories?

#167891606

Screenshots (if appropriate)

image

image

@femitj femitj added the wip label Sep 15, 2019
@femitj
femitj requested review from thatkazuk1 and removed request for thatkazuk1 September 15, 2019 20:36
Comment thread test/mockData/mockBooking.js Outdated
accomodationId: '3dd3b34a-7554-425e-a688-36afda199619',
roomId: '3dd3b34a-1254-495e-a688-36afda133619',
bookDate: '2019-09-15',
bookDate: '2020-09-15',

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a future bug. This test will fail on 2020-09-15 😁

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lol You're right!

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😆😆

@femitj
femitj force-pushed the ft-rate-centre-167891606 branch 2 times, most recently from 8812dbe to 0f0fdc0 Compare September 16, 2019 09:00
 - Creates rating model and migration
 - Creates seeders
 - Writes tests
 [finishes #167891606]
@femitj
femitj force-pushed the ft-rate-centre-167891606 branch from 0f0fdc0 to 702a50b Compare September 16, 2019 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants