Skip to content

feat: migrate API key storage to SecretStorage API#746

Merged
andi1984 merged 1 commit into
developfrom
739-security-migrate-api-key-storage-to-secretstorage-api
Dec 26, 2025
Merged

feat: migrate API key storage to SecretStorage API#746
andi1984 merged 1 commit into
developfrom
739-security-migrate-api-key-storage-to-secretstorage-api

Conversation

@andi1984

Copy link
Copy Markdown
Owner

Addresses security vulnerability where API keys were stored in plain text in settings.json, risking accidental version control exposure and settings sync leakage.

Changes:

  • ConfigService now uses VSCode SecretStorage for secure credential storage
  • Added 'TinyPNG: Set API Key' command for secure key input (password masked)
  • Deprecated tinypng.apiKey setting with migration message
  • Auto-migrates existing API keys from settings to SecretStorage
  • Made activation async to support SecretStorage operations

Closes #739

🤖 Generated with Claude Code

@andi1984 andi1984 linked an issue Dec 26, 2025 that may be closed by this pull request
Addresses security vulnerability where API keys were stored in plain text
in settings.json, risking accidental version control exposure and settings
sync leakage.

Changes:
- ConfigService now uses VSCode SecretStorage for secure credential storage
- Added 'TinyPNG: Set API Key' command for secure key input (password masked)
- Deprecated tinypng.apiKey setting with migration message
- Auto-migrates existing API keys from settings to SecretStorage
- Made activation async to support SecretStorage operations

Closes #739

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
@andi1984
andi1984 force-pushed the 739-security-migrate-api-key-storage-to-secretstorage-api branch from e4a34ef to 19e1b6c Compare December 26, 2025 18:51
@andi1984
andi1984 merged commit 0258198 into develop Dec 26, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Security: Migrate API key storage to SecretStorage API

1 participant